gh-69093: Support basic incremental I/O to blobs in sqlite3
#30680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
Apr 12, 2022
|
Some tests need to be updated with new error messages |
|
FYI, I'll prepare PRs for adding mapping protocol and context manager support. |
AlexWaygood
reviewed
Apr 14, 2022
|
Thanks for reviewing, both of you :) |
added 2 commits
April 15, 2022 00:52
|
BTW, I went over the review comments on the original PR; it seems that the following two comments by Berker are not addressed yet:
I think we should heed those suggestions. If you are ok with that, I'll fix those right away. proposed patchcommit 69a5a1e2453710a34bfaf7863f94ea9dacefbedf (HEAD -> sqlite-blob-reduced)
Author: Erlend E. Aasland <erlend.aasland@innova.no>
Date: Fri Apr 15 00:53:09 2022 +0200
Address Berker's comments from gh-271: move __len__ doc to class description
diff --git a/Doc/library/sqlite3.rst b/Doc/library/sqlite3.rst
index 992256c134..d0274fb797 100644
--- a/Doc/library/sqlite3.rst
+++ b/Doc/library/sqlite3.rst
@@ -1115 +1115,2 @@ Blob Objects
- data in an SQLite :abbr:`BLOB (Binary Large OBject)`.
+ data in an SQLite :abbr:`BLOB (Binary Large OBject)`. Call ``len(blob)`` to
+ get the size (number of bytes) of the blob.
@@ -1125,4 +1125,0 @@ Blob Objects
- .. method:: __len__()
-
- Return the blob size in bytes.
-
commit 2590112aff8ec625aa5d1debb8fdc10f36fa3017
Author: Erlend E. Aasland <erlend.aasland@innova.no>
Date: Fri Apr 15 00:52:47 2022 +0200
Address Berker's comments from gh-271: remove unneeded class prefix
diff --git a/Doc/library/sqlite3.rst b/Doc/library/sqlite3.rst
index 0d4dbdf64d..992256c134 100644
--- a/Doc/library/sqlite3.rst
+++ b/Doc/library/sqlite3.rst
@@ -1117 +1117 @@ Blob Objects
- .. method:: Blob.close()
+ .. method:: close()
@@ -1125 +1125 @@ Blob Objects
- .. method:: Blob.__len__()
+ .. method:: __len__()
@@ -1129 +1129 @@ Blob Objects
- .. method:: Blob.read(length=-1, /)
+ .. method:: read(length=-1, /)
@@ -1137 +1137 @@ Blob Objects
- .. method:: Blob.write(data, /)
+ .. method:: write(data, /)
@@ -1143 +1143 @@ Blob Objects
- .. method:: Blob.tell()
+ .. method:: tell()
@@ -1147 +1147 @@ Blob Objects
- .. method:: Blob.seek(offset, origin=os.SEEK_SET, /)
+ .. method:: seek(offset, origin=os.SEEK_SET, /)
|
|
Sounds good, but I think your two patches conflict with each other. |
JelleZijlstra
approved these changes
Apr 14, 2022
dholth
reviewed
Apr 15, 2022
This was referenced Apr 15, 2022
JelleZijlstra
added a commit
to JelleZijlstra/typeshed
that referenced
this pull request
Apr 15, 2022
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged) - Aggregate window functions from python/cpython#20903 - Serialize/deserialize from python/cpython#26728 - Limit setting from python/cpython#28463
|
@erlend-aasland I wanted to say thank you for making this happen. Crazy it took more then 6 years to merge this... |
Thanks for paving the way, and thanks for having done so much for the sqlite3 module. Yeah, PRs can end up hanging for years before being merged. Better late than never, I guess :) (Also, I hope you're ok with the changes I've applied to your code.) |
srittau
pushed a commit
to python/typeshed
that referenced
this pull request
Apr 16, 2022
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged) - Aggregate window functions from python/cpython#20903 - Serialize/deserialize from python/cpython#26728 - Limit setting from python/cpython#28463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authored-by: Aviv Palivoda palaviv@gmail.com
Co-authored-by: Erlend E. Aasland erlend.aasland@innova.no
gh-69093