bpo-45243: Add support for setting/getting sqlite3 connection limits
#28463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thinking about this, I wonder if connection limits are better implemented as attributes: import sqlite3
cx = sqlite3.connect(":memory:")
lim = cx.SQLITE_LIMIT_LENGTH
cx.SQLITE_LIMIT_LENGTH = 100
# instead of
lim = cx.getlimit(sqlite3.SQLITE_LIMIT_LENGTH)
cx.setlimit(sqlite3.SQLITE_LIMIT_LENGTH, 100)I added GH-28790 as an alternative implementation. |
added 3 commits
October 7, 2021 20:46
- Use 'category' for limit category - Use 'limit' for the new limit
|
@serhiy-storchaka I changed the argument spec:
I believe this is clearer and more aligned with the SQLite documentation. |
|
PTAL, @serhiy-storchaka. |
|
@serhiy-storchaka I believe all comments have been resolved. Would you like to take another look at this PR? |
|
@pablogsal would you mind taking a look at this? I believe I've addressed all of Serhiy's comments. |
JelleZijlstra
added a commit
to JelleZijlstra/typeshed
that referenced
this pull request
Apr 15, 2022
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged) - Aggregate window functions from python/cpython#20903 - Serialize/deserialize from python/cpython#26728 - Limit setting from python/cpython#28463
srittau
pushed a commit
to python/typeshed
that referenced
this pull request
Apr 16, 2022
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged) - Aggregate window functions from python/cpython#20903 - Serialize/deserialize from python/cpython#26728 - Limit setting from python/cpython#28463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45243