Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45243: Expose SQLite connection limits as sqlite3.Connection attributes #28790

Closed
wants to merge 5 commits into from
Closed

bpo-45243: Expose SQLite connection limits as sqlite3.Connection attributes #28790

wants to merge 5 commits into from

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Oct 7, 2021 •
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
Contributor Author

Proposed alternative to #28463.

@erlend-aasland erlend-aasland mentioned this pull request Oct 7, 2021
Merged
@erlend-aasland erlend-aasland force-pushed the sqlite-limits-as-attributes branch from e0da443 to a0c1251 Compare October 7, 2021 12:51
erlend-aasland
erlend-aasland commented Oct 7, 2021
View reviewed changes
Modules/_sqlite/connection.c
static const char connection_doc[] =
PyDoc_STR("SQLite database connection object.");

#define DEF_LIMIT_GETSET(limit, doc) \
{#limit, (getter)get_limit, (setter)set_limit, doc, (void *)limit},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casting the limit macros to void * and back again to int is perhaps a little bit too hackish. But it does allow for a single getter/setter.

@erlend-aasland erlend-aasland force-pushed the sqlite-limits-as-attributes branch from a0c1251 to f4b9fcd Compare October 7, 2021 12:56
@erlend-aasland erlend-aasland force-pushed the sqlite-limits-as-attributes branch from 5ec4adb to d04794d Compare October 7, 2021 13:29
@serhiy-storchaka
Copy link
Member 

old = con.SQLITE_LIMIT_LENGTH
con.SQLITE_LIMIT_LENGTH = new

does not look nice to me. If go this way, I would prefer

old = con.limit.length
con.limit.length = new

But do we have precedences of such getters and setters in the stdlib?

There are also disadvantages in comparison with traditional getlimit()/setlimit().

  1. setlimit() sets a new limit and returns an old limit at one operation. Atomically (guarded by the GIL).
  2. getlimit()/setlimit() can be used for new limits not supported by the sqlite3 module yet. Just use some numeric constant.

@erlend-aasland
Copy link
Contributor Author

I'm not aware of similar attributes in the stdlib. I have no strong preference regarding this approach and GH-28463. I'm fine with closing this in favour of GH-28463.

@erlend-aasland erlend-aasland deleted the sqlite-limits-as-attributes branch October 7, 2021 18:47
@erlend-aasland
Copy link
Contributor Author

This approach will be more tedious to maintain. I'm closing this in favour of GH-28463.

@erlend-aasland erlend-aasland mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot