Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-1635741: Port _posixshmem extension module to multiphase initialization #23404

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 19, 2020

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue1635741

Automerge-Triggered-By: GH:tiran

Signed-off-by: Christian Heimes <christian@python.org>
@tiran
Copy link
Member Author

tiran commented Nov 19, 2020

@corona10 Most trivial port ever

@tiran tiran changed the title Port _posixshmem extension module to multiphase initialization bpo-1635741: Port _posixshmem extension module to multiphase initialization Nov 19, 2020
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -0,0 +1 @@
Port _posixshmem extension module to multiphase initialization (:pep:`489`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: would you mind to add a trialing dot? :-)

Suggested change
Port _posixshmem extension module to multiphase initialization (:pep:`489`)
Port _posixshmem extension module to multiphase initialization (:pep:`489`).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time!

@miss-islington miss-islington merged commit b437aa8 into python:master Nov 19, 2020
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.x has failed when building commit b437aa8.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/146/builds/422) and take a look at the build logs.
  4. Check if the failure is related to this commit (b437aa8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/146/builds/422

Summary of the results of the build (if available):

Click to see traceback logs
remote: Enumerating objects: 18, done.        
remote: Counting objects:   5% (1/18)        
remote: Counting objects:  11% (2/18)        
remote: Counting objects:  16% (3/18)        
remote: Counting objects:  22% (4/18)        
remote: Counting objects:  27% (5/18)        
remote: Counting objects:  33% (6/18)        
remote: Counting objects:  38% (7/18)        
remote: Counting objects:  44% (8/18)        
remote: Counting objects:  50% (9/18)        
remote: Counting objects:  55% (10/18)        
remote: Counting objects:  61% (11/18)        
remote: Counting objects:  66% (12/18)        
remote: Counting objects:  72% (13/18)        
remote: Counting objects:  77% (14/18)        
remote: Counting objects:  83% (15/18)        
remote: Counting objects:  88% (16/18)        
remote: Counting objects:  94% (17/18)        
remote: Counting objects: 100% (18/18)        
remote: Counting objects: 100% (18/18), done.        
remote: Compressing objects:  12% (1/8)        
remote: Compressing objects:  25% (2/8)        
remote: Compressing objects:  37% (3/8)        
remote: Compressing objects:  50% (4/8)        
remote: Compressing objects:  62% (5/8)        
remote: Compressing objects:  75% (6/8)        
remote: Compressing objects:  87% (7/8)        
remote: Compressing objects: 100% (8/8)        
remote: Compressing objects: 100% (8/8), done.        
remote: Total 10 (delta 8), reused 3 (delta 2), pack-reused 0        
From https://github.com/python/cpython
 * branch            master     -> FETCH_HEAD
Reset branch 'master'

Invoke-WebRequest : The request was aborted: Could not create SSL/TLS secure 
channel.
At line:1 char:1
+ Invoke-WebRequest https://aka.ms/nugetclidl -OutFile 'D:\buildarea\3. ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:Htt 
   pWebRequest) [Invoke-WebRequest], WebException
    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShe 
   ll.Commands.InvokeWebRequestCommand
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\buildarea\3.x.bolen-windows10\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
Invoke-WebRequest : The request was aborted: Could not create SSL/TLS secure 
channel.
At line:1 char:1
+ Invoke-WebRequest https://aka.ms/nugetclidl -OutFile 'D:\buildarea\3. ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:Htt 
   pWebRequest) [Invoke-WebRequest], WebException
    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShe 
   ll.Commands.InvokeWebRequestCommand
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\buildarea\3.x.bolen-windows10\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
Could Not Find D:\buildarea\3.x.bolen-windows10\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\buildarea\3.x.bolen-windows10\build\PCbuild\python*.zip
Invoke-WebRequest : The request was aborted: Could not create SSL/TLS secure 
channel.
At line:1 char:1
+ Invoke-WebRequest https://aka.ms/nugetclidl -OutFile 'D:\buildarea\3. ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:Htt 
   pWebRequest) [Invoke-WebRequest], WebException
    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShe 
   ll.Commands.InvokeWebRequestCommand
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\buildarea\3.x.bolen-windows10\build\PCbuild\\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.

test_ioctl skipped -- No module named 'fcntl'
test_kqueue skipped -- test works only on BSD
test_ossaudiodev skipped -- No module named 'ossaudiodev'
test_fcntl skipped -- No module named 'fcntl'
test_fork1 skipped -- object <module 'os' from 'D:\\buildarea\\3.x.bolen-windows10\\build\\lib\\os.py'> has no attribute 'fork'
test_pty skipped -- No module named 'termios'
test_wait4 skipped -- object <module 'os' from 'D:\\buildarea\\3.x.bolen-windows10\\build\\lib\\os.py'> has no attribute 'fork'
test_multiprocessing_forkserver skipped -- forkserver is not available on Windows
test_resource skipped -- No module named 'resource'
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
minkernel\crts\ucrt\src\appcrt\lowio\write.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
minkernel\crts\ucrt\src\appcrt\lowio\close.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
minkernel\crts\ucrt\src\appcrt\lowio\close.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
test_readline skipped -- No module named 'readline'
test_grp skipped -- No module named 'grp'
test_pipes skipped -- pipes module only works on posix
test_threadsignals skipped -- Can't test signal on win32
test_multiprocessing_fork skipped -- fork is not available on Windows
test_syslog skipped -- No module named 'syslog'
minkernel\crts\ucrt\src\appcrt\lowio\write.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
test_posix skipped -- No module named 'posix'
test_dbm_ndbm skipped -- No module named '_dbm'
test_epoll skipped -- test works only on Linux 2.6
test_dbm_gnu skipped -- No module named '_gdbm'
test_openpty skipped -- os.openpty() not available.
test_pwd skipped -- No module named 'pwd'
test_poll skipped -- select.poll not defined
test_devpoll skipped -- test works only on Solaris OS family
test_spwd skipped -- No module named 'spwd'
test_nis skipped -- No module named 'nis'
test_curses skipped -- No module named '_curses'
test_xxtestfuzz skipped -- No module named '_xxtestfuzz'
test_gdb skipped -- Couldn't find gdb on the path
test_wait3 skipped -- os.fork not defined
<string>:2: PendingDeprecationWarning: lib2to3 package is deprecated and may not be able to parse Python 3.10+

Cannot open file 'D:\buildarea\3.x.bolen-windows10\build\test-results.xml' for upload

Invoke-WebRequest : The request was aborted: Could not create SSL/TLS secure 
channel.
At line:1 char:1
+ Invoke-WebRequest https://aka.ms/nugetclidl -OutFile 'D:\buildarea\3. ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:Htt 
   pWebRequest) [Invoke-WebRequest], WebException
    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShe 
   ll.Commands.InvokeWebRequestCommand
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\buildarea\3.x.bolen-windows10\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
Invoke-WebRequest : The request was aborted: Could not create SSL/TLS secure 
channel.
At line:1 char:1
+ Invoke-WebRequest https://aka.ms/nugetclidl -OutFile 'D:\buildarea\3. ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:Htt 
   pWebRequest) [Invoke-WebRequest], WebException
    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShe 
   ll.Commands.InvokeWebRequestCommand
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\buildarea\3.x.bolen-windows10\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
Could Not Find D:\buildarea\3.x.bolen-windows10\build\PCbuild\python*.zip

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
…zation (pythonGH-23404)

Signed-off-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants