Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-1635741: Port _posixshmem extension module to multiphase initialization #23404

Merged
merged 1 commit into from
Nov 19, 2020
Merged

bpo-1635741: Port _posixshmem extension module to multiphase initialization #23404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/C API/2020-11-19-15-33-42.bpo-1635741.9tVsZt.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Port _posixshmem extension module to multiphase initialization (:pep:`489`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: would you mind to add a trialing dot? :-)

Suggested change
Port _posixshmem extension module to multiphase initialization (:pep:`489`)
Port _posixshmem extension module to multiphase initialization (:pep:`489`).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time!

22 changes: 9 additions & 13 deletions Modules/_multiprocessing/posixshmem.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,21 +110,17 @@ static PyMethodDef module_methods[ ] = {
};


static struct PyModuleDef this_module = {
PyModuleDef_HEAD_INIT, // m_base
"_posixshmem", // m_name
"POSIX shared memory module", // m_doc
-1, // m_size (space allocated for module globals)
module_methods, // m_methods
static struct PyModuleDef _posixshmemmodule = {
PyModuleDef_HEAD_INIT,
.m_name = "_posixshmem",
.m_doc = "POSIX shared memory module",
.m_size = 0,
.m_methods = module_methods,
};

/* Module init function */
PyMODINIT_FUNC
PyInit__posixshmem(void) {
PyObject *module;
module = PyModule_Create(&this_module);
if (!module) {
return NULL;
}
return module;
PyInit__posixshmem(void)
{
return PyModuleDef_Init(&_posixshmemmodule);
}