Skip to content

bpo-42773: fix tests not being run on pushes #24004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2020
Merged

bpo-42773: fix tests not being run on pushes #24004

merged 1 commit into from
Dec 30, 2020

Conversation

FFY00
Copy link
Member

@FFY00 FFY00 commented Dec 29, 2020 •
edited by miss-islington
Loading

There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns lains@riseup.net

https://bugs.python.org/issue42773

Automerge-Triggered-By: GH:Mariatta

Mariatta
Mariatta approved these changes Dec 30, 2020
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. I think the news file is not needed though. Would you be able to remove it. I have already applied the "skip news" label.

@FFY00
bpo-42773: fix tests not being run on pushes
f0d4699 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Copy link
Member Author

FFY00 commented Dec 30, 2020

Done 😊

@miss-islington miss-islington merged commit 4ac923f into python:master Dec 30, 2020
@Mariatta
Copy link
Member

Thanks!

@miss-islington
Copy link
Contributor

Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-24010 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2020
@FFY00 @miss-islington
bpo-42773: fix tests not being run on pushes (pythonGH-24004)
477088f 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <lains@riseup.net>
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns <lains@riseup.net>
@bedevere-bot
Copy link

GH-24011 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Dec 30, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2020
@FFY00 @miss-islington
bpo-42773: fix tests not being run on pushes (pythonGH-24004)
4627140 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <lains@riseup.net>
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns <lains@riseup.net>
@miss-islington
Copy link
Contributor

Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-24437 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2021
@FFY00 @miss-islington
bpo-42773: fix tests not being run on pushes (pythonGH-24004)
6840cdf 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <lains@riseup.net>
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns <lains@riseup.net>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2021
@FFY00 @miss-islington
bpo-42773: fix tests not being run on pushes (pythonGH-24004)
8d86caf 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <lains@riseup.net>
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns <lains@riseup.net>
@bedevere-bot
Copy link

GH-24438 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Feb 3, 2021
miss-islington added a commit that referenced this pull request Feb 3, 2021
@miss-islington @FFY00
bpo-42773: fix tests not being run on pushes (GH-24004)
d29dbb1 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <lains@riseup.net>
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns <lains@riseup.net>
miss-islington added a commit that referenced this pull request Feb 3, 2021
@miss-islington @FFY00
bpo-42773: fix tests not being run on pushes (GH-24004)
0898dcb 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <lains@riseup.net>
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns <lains@riseup.net>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@FFY00 @adorilson
bpo-42773: fix tests not being run on pushes (pythonGH-24004)
95bf79e 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <lains@riseup.net>
@erlend-aasland erlend-aasland mentioned this pull request May 5, 2022
Merged
@miss-islington
Copy link
Contributor

Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-92341 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 5, 2022
@FFY00 @miss-islington
bpo-42773: fix tests not being run on pushes (pythonGH-24004)
86dd591 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <lains@riseup.net>
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns <lains@riseup.net>
ned-deily pushed a commit that referenced this pull request May 6, 2022
@miss-islington
bpo-42773: fix tests not being run on pushes (GH-24004) (GH-92341)
5adef3d 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <lains@riseup.net>
(cherry picked from commit 4ac923f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@FFY00 @Mariatta @miss-islington @bedevere-bot @JelleZijlstra @the-knights-who-say-ni