-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
[3.7] gh-80254: Disallow recursive usage of cursors in sqlite3 converters #92334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.7] gh-80254: Disallow recursive usage of cursors in sqlite3 converters #92334
Conversation
…` converters (cherry picked from commit c908dc5) Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit d52fd31 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
CI cannot find merge base, and decides that this is not worthy running the tests. Buildbots seem to ignore this fact though, so I guess that it's fine if they are green. UPDATE: a little bit too fast there; AMD64 FreeBSD Non-Debug is green, but it did not run. It failed before even compiling. |
This buildbot run does not look good. Do you experience this often on the 3.7 branch, @ambv? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not allowed to merge until regular CI passes (the check is required). Code looks good to me but we'll have to figure out what's up with CI.
I think it is related to 4ac923f |
See also GH-21806 |
Great! I'll pull in 3.7 when the backports land. |
The 3.7 branch no longer accept bugfixes, only security fixes: https://devguide.python.org/#status-of-python-branches Do you consider that this change fix a security issue? |
Yes, see discussion here. |
(cherry picked from commit c908dc5)
Co-authored-by: Sergey Fedoseev fedoseev.sergey@gmail.com
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com