bpo-28556: Various updates to typing #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
approved these changes
Feb 12, 2017
|
Oh, this should probably also include a Misc/NEWS update. |
|
I added a short entry (note that there is no issue for this, so that I referenced this PR #28) |
|
How about http://bugs.python.org/issue28556 ?
|
|
OK, I added the reference to the omnibus issue. |
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 82.37% 82.38% +0.01%
==========================================
Files 1427 1428 +1
Lines 350948 351138 +190
==========================================
+ Hits 289088 289285 +197
+ Misses 61860 61853 -7Continue to review full report at Codecov.
|
ilevkivskyi
changed the title
|
I'm hoping some core dev will take kindly to this and merge it. |
brettcannon
approved these changes
Feb 13, 2017
|
LGTM, but I don't have the time to do the merge + cherry-picks on this. |
|
Will cherry-pick shortly |
Mariatta
referenced
this pull request
in Mariatta/cpython
Feb 13, 2017
various updates from upstream python/typing repo: - Added typing.Counter and typing.ChainMap generics - More flexible typing.NamedTuple - Improved generic ABC caching - More tests - Bugfixes - Other updates * Add Misc/NEWS entry * Add issue number (cherry picked from commit b692dc8)
Mariatta
referenced
this pull request
in Mariatta/cpython
Feb 13, 2017
various updates from upstream python/typing repo: - Added typing.Counter and typing.ChainMap generics - More flexible typing.NamedTuple - Improved generic ABC caching - More tests - Bugfixes - Other updates * Add Misc/NEWS entry * Add issue number (cherry picked from commit b692dc8)
Mariatta
added a commit
that referenced
this pull request
Feb 13, 2017
various updates from upstream python/typing repo: - Added typing.Counter and typing.ChainMap generics - More flexible typing.NamedTuple - Improved generic ABC caching - More tests - Bugfixes - Other updates * Add Misc/NEWS entry * Add issue number Contributed by Ivan Levkivskyi @ilevkivskyi (cherry picked from commit b692dc8)
|
@Mariatta Thank you very much for taking care of this! |
|
Thank you both! I love the new workflows.
|
Mariatta
added a commit
that referenced
this pull request
Feb 14, 2017
various updates from upstream python/typing repo: - Added typing.Counter and typing.ChainMap generics - More flexible typing.NamedTuple - Improved generic ABC caching - More tests - Bugfixes - Other updates * Add Misc/NEWS entry (cherry picked from commit b692dc8)
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
- Ensure travis job has kicked off before checking for `pending` status.
jaraco
pushed a commit
to jaraco/cpython
that referenced
this pull request
Feb 17, 2023
jaraco
added a commit
to jaraco/cpython
that referenced
this pull request
Feb 17, 2023
* Use `extend-ignore` in flake8 config This option allows to add extra ignored rules to the default list instead of replacing it. The default exclusions are: E121, E123, E126, E226, E24, E704, W503 and W504. Fixes python#28. Refs: * https://github.com/pypa/setuptools/pull/2486/files#r541943356 * https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-extend-ignore * https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-ignore * Enable complexity limit. Fixes jaraco/skeleton#34. * Replace pep517.build with build (python#37) * Replace pep517.build with build Resolves python#30 * Prefer simple usage Co-authored-by: Jason R. Coombs <jaraco@jaraco.com> * Use license_files instead of license_file in meta (python#35) Singular `license_file` is deprecated since wheel v0.32.0. Refs: * https://wheel.readthedocs.io/en/stable/news.html * https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
nanjekyejoannah
added a commit
to nanjekyejoannah/cpython
that referenced
this pull request
May 22, 2023
28: test clean final r=ltratt a=nanjekyejoannah This PR does the final cleanups to address the following: - Allow higher recursion limit for some tests - skip some tests that require very high recursion limits, I used the allowed limit by convention for the first item above - call reset to allow warning propagation in some tests Note: Existing py3k tests fail with a segfault with -3 flag if not run individually, deleting this context manager in over 300 files will take forever, lets only run `test_py3kwarn` and the rest should be tested locally if modified. It took me long to know the source of this segfault, I have solved any issues with new context manager I introduce. If this PR is merged, we can modify the CI, I am going back to implementing the warnings now. Co-authored-by: Joannah Nanjekye <jnanjeky@unb.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various updates from upstream
python/typingrepo:typing.Counterandtyping.ChainMapgenericstyping.NamedTupleThis should be backported to 3.6 and 3.5 branches.