Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport to 2.7] Change documentation's Show Source link to GitHub #44

Merged
merged 2 commits into from
Feb 12, 2017
Merged

[backport to 2.7] Change documentation's Show Source link to GitHub #44

merged 2 commits into from
Feb 12, 2017

Conversation

Mariatta
Copy link
Member

@Mariatta Mariatta commented Feb 12, 2017 •
edited
Loading

Change documentation's Show Source link to GitHub (2.7 branch)
Render issue role as bpo-NNNN

@Mariatta
Support "bpo-" in Misc/NEWS (#1)
63b8f25 
Change the url to 2.7

(cherry picked from commit 79ab8be)
methane
methane reviewed Feb 12, 2017
View reviewed changes
Doc/tools/extensions/pyspecific.py Outdated
@@ -58,7 +58,7 @@ def new_depart_literal_block(self, node):

def issue_role(typ, rawtext, text, lineno, inliner, options={}, content=[]):
issue = utils.unescape(text)
text = 'issue ' + issue
text = 'bpo- ' + issue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there space between 'bpo-' and issue number?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there shouldn't be a space 😅
Thanks for the review :) Will fix soon.

@methane
Copy link
Member

methane commented Feb 12, 2017

Hm, the title of pull request is bit misleading. doc of Python 2.7 doesn't include Misc/NEWS.
But this pull request backports these changes.

  • Change link target of "Source code:" from hg.python.org to github
  • issue role (:issue:`1234`) rendered as "bpo-1234" instead of "issue 1234" (example)

methane
methane approved these changes Feb 12, 2017
View reviewed changes
Copy link
Member

@methane methane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did make html in local, and it works as expected.
LGTM.

@Mariatta Mariatta changed the title [backport to 2.7] Support "bpo-" in Misc/NEWS [backport to 2.7] Change documentation's Show Source link to GitHub Feb 12, 2017
@Mariatta
Copy link
Member Author

Thanks @methane :) I updated the pull request description.
What do you think?

@methane
Copy link
Member

methane commented Feb 12, 2017

LGTM

@Mariatta Mariatta merged commit 52b8c55 into python:2.7 Feb 12, 2017
@Mariatta Mariatta deleted the bpo-news-support-2.7 branch February 12, 2017 20:59
gnprice added a commit to gnprice/cpython that referenced this pull request Aug 15, 2019
@gnprice
bpo-36502: Update link to UAX python#44, the Unicode doc on the UCD.
db85e15 
The link we have points to the version from Unicode 6.0.0, dated 2010.
There have been numerous updates to it since then:
  https://www.unicode.org/reports/tr44/#Modifications

Change the link to one that points to the current version.
benjaminp pushed a commit that referenced this pull request Sep 9, 2019
@gnprice @benjaminp
bpo-36502: Update link to UAX #44, the Unicode doc on the UCD. (GH-15301
64c6ac7 
)

The link we have points to the version from Unicode 6.0.0, dated 2010.
There have been numerous updates to it since then:
  https://www.unicode.org/reports/tr44/#Modifications

Change the link to one that points to the current version. Also, use HTTPS.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2019
@gnprice @miss-islington
bpo-36502: Update link to UAX pythonGH-44, the Unicode doc on the UCD. (
b6247fe 
pythonGH-15301)

The link we have points to the version from Unicode 6.0.0, dated 2010.
There have been numerous updates to it since then:
  https://www.unicode.org/reports/tr44/GH-Modifications

Change the link to one that points to the current version. Also, use HTTPS.
(cherry picked from commit 64c6ac7)

Co-authored-by: Greg Price <gnprice@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2019
@gnprice @miss-islington
bpo-36502: Update link to UAX pythonGH-44, the Unicode doc on the UCD. (
b6150cd 
pythonGH-15301)

The link we have points to the version from Unicode 6.0.0, dated 2010.
There have been numerous updates to it since then:
  https://www.unicode.org/reports/tr44/GH-Modifications

Change the link to one that points to the current version. Also, use HTTPS.
(cherry picked from commit 64c6ac7)

Co-authored-by: Greg Price <gnprice@gmail.com>
benjaminp pushed a commit that referenced this pull request Sep 9, 2019
@gnprice @benjaminp
[2.7] bpo-36502: Update link to UAX GH-44, the Unicode doc on the UCD. (
bf30da2 
GH-15301)

The link we have points to the version from Unicode 6.0.0, dated 2010.
There have been numerous updates to it since then:
  https://www.unicode.org/reports/tr44/GH-Modifications

Change the link to one that points to the current version. Also, use HTTPS..
(cherry picked from commit 64c6ac7)

Co-authored-by: Greg Price <gnprice@gmail.com>
benjaminp added a commit that referenced this pull request Sep 9, 2019
@benjaminp @gnprice
[2.7] bpo-36502: Update link to UAX GH-44, the Unicode doc on the UCD. (
58d61ef 
GH-15808)

The link we have points to the version from Unicode 6.0.0, dated 2010.
There have been numerous updates to it since then:
  https://www.unicode.org/reports/tr44/GH-Modifications

Change the link to one that points to the current version. Also, use HTTPS..
(cherry picked from commit 64c6ac7)

Co-authored-by: Greg Price <gnprice@gmail.com>
miss-islington added a commit that referenced this pull request Sep 9, 2019
@miss-islington @gnprice
bpo-36502: Update link to UAX GH-44, the Unicode doc on the UCD. (GH-…
0a86da8 
…15301)

The link we have points to the version from Unicode 6.0.0, dated 2010.
There have been numerous updates to it since then:
  https://www.unicode.org/reports/tr44/GH-Modifications

Change the link to one that points to the current version. Also, use HTTPS.
(cherry picked from commit 64c6ac7)

Co-authored-by: Greg Price <gnprice@gmail.com>
miss-islington added a commit that referenced this pull request Sep 9, 2019
@miss-islington @gnprice
bpo-36502: Update link to UAX GH-44, the Unicode doc on the UCD. (GH-…
c1c04cb 
…15301)

The link we have points to the version from Unicode 6.0.0, dated 2010.
There have been numerous updates to it since then:
  https://www.unicode.org/reports/tr44/GH-Modifications

Change the link to one that points to the current version. Also, use HTTPS.
(cherry picked from commit 64c6ac7)

Co-authored-by: Greg Price <gnprice@gmail.com>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@gnprice @websurfer5
bpo-36502: Update link to UAX python#44, the Unicode doc on the UCD. (p…
2bc1dd4 
…ythonGH-15301)

The link we have points to the version from Unicode 6.0.0, dated 2010.
There have been numerous updates to it since then:
  https://www.unicode.org/reports/tr44/#Modifications

Change the link to one that points to the current version. Also, use HTTPS.
iritkatriel referenced this pull request in iritkatriel/cpython Jul 22, 2021
@iritkatriel
Refactor perf script to separate load from exec (#44)
1ba8909
@DavidNemeskey DavidNemeskey mentioned this pull request May 12, 2022
Open
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@warsaw
Merge branch 'issue44' into 'master'
afe14c3 
Fix `contents()` so that it no longer returns unrelated items

Closes python#44

See merge request python-devs/importlib_resources!48
oraluben pushed a commit to oraluben/cpython that referenced this pull request Jun 26, 2023
@Fidget-Spinner
docs: instructions for trying out binaries (python#44)
0af2c7e
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
Closed
@LinanV LinanV mentioned this pull request Oct 23, 2023
Closed
@kcatss kcatss mentioned this pull request Feb 20, 2024
Closed
@ngoldbaum ngoldbaum mentioned this pull request Sep 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mariatta @methane @the-knights-who-say-ni