Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-69093: Add mapping protocol support to sqlite3.Blob #91599

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 16, 2022

Originally written by @palaviv in gh-271.

Authored-by: Aviv Palivoda palaviv@gmail.com
Co-authored-by: Erlend E. Aasland erlend.aasland@innova.no

gh-69093

@erlend-aasland
Copy link
Contributor Author

Let's land GH-91561 first.

Authored-by: Aviv Palivoda <palaviv@gmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
@erlend-aasland erlend-aasland force-pushed the sqlite-blob-add-mapping-protocol branch from a84e0fb to 38b2cdb Compare April 16, 2022 07:15
@JelleZijlstra
Copy link
Member

Let's land GH-91561 first.

Done, could you fix the conflict? I'll also review the code for this one now.

@erlend-aasland erlend-aasland marked this pull request as draft April 16, 2022 17:56
@erlend-aasland erlend-aasland marked this pull request as ready for review April 17, 2022 07:53
@JelleZijlstra JelleZijlstra self-requested a review April 18, 2022 22:25
…lMwI.rst

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstra JelleZijlstra merged commit 29afb7d into python:main Apr 22, 2022
@erlend-aasland erlend-aasland deleted the sqlite-blob-add-mapping-protocol branch April 22, 2022 07:44
@erlend-aasland
Copy link
Contributor Author

Thanks a lot, Jelle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants