Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite3: Add sequence methods to Blob #7684

Merged
merged 1 commit into from
Apr 26, 2022
Merged

sqlite3: Add sequence methods to Blob #7684

merged 1 commit into from
Apr 26, 2022

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Apr 26, 2022 •
edited
Loading

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

hauntsaninja
hauntsaninja approved these changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to be too crass, but I do enjoy the function name blob_ass_subscript

@JelleZijlstra JelleZijlstra merged commit 125f9b4 into master Apr 26, 2022
@JelleZijlstra JelleZijlstra deleted the JelleZijlstra-patch-2 branch April 26, 2022 03:17
@Akuli
Copy link
Collaborator

Akuli commented Apr 26, 2022

I find it weird that blob[0] returns bytes. With bytes, bytearray or memoryview, it would return a byte as int.

@JelleZijlstra JelleZijlstra mentioned this pull request Apr 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JelleZijlstra @Akuli @hauntsaninja