-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-95736: Fix event loop creation in IsolatedAsyncioTestCase #96033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-95736: Fix event loop creation in IsolatedAsyncioTestCase #96033
Conversation
It should be created before calling the setUp() method, but after checking for skipping a test.
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 1194f25 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
I have a new ticket and PR GH-96031 |
Well, this fix sure looks simpler than @tiran's. I'll defer judgment until I've had time to look at things more thoroughly though. |
Let's merge this PR to unblock and fix main branch. We can solve #95736 and correct the problematic implementation in the async unittest helper later. |
The wasm32-wasi PR build fails with a different error:
|
Tho other WASM builds are fine. @tiran what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the failing buildbots are explained this LGTM.
It's an unrelated error which is already fixed in main. |
@serhiy-storchaka: Status check is done, and it's a pending ❌ . |
1 similar comment
@serhiy-storchaka: Status check is done, and it's a pending ❌ . |
Status check is done, and it's a success ✅ . |
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry @serhiy-storchaka, I had trouble checking out the |
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
GH-96041 is a backport of this pull request to the 3.11 branch. |
…ythonGH-96033) It should be created before calling the setUp() method, but after checking for skipping a test. Automerge-Triggered-By: GH:tiran (cherry picked from commit 3651710) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
It should be created before calling the setUp() method, but after
checking for skipping a test.
IsolatedAsyncioTestCase
does not callasyncio.set_event_loop
beforesetUp
anymore,asyncio.Runner
+PidFdChildWatcher
leaves zombie processes #95736Automerge-Triggered-By: GH:tiran