Skip to content

gh-95736: Fix event loop creation in IsolatedAsyncioTestCase #96033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2022
Merged

gh-95736: Fix event loop creation in IsolatedAsyncioTestCase #96033

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1194f25
gh-95736: Fix event loop creation in IsolatedAsyncioTestCase
serhiy-storchaka Aug 16, 2022
ef7e7f6
Merge branch 'main' into unittest-async-case-event-loop-setup
tiran Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Lib/unittest/async_case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ async def enterAsyncContext(self, cm):
return result

def _callSetUp(self):
# Force loop to be initialized and set as the current loop
# so that setUp functions can use get_event_loop() and get the
# correct loop instance.
self._asyncioRunner.get_loop()
self._asyncioTestContext.run(self.setUp)
self._callAsync(self.asyncSetUp)

Expand Down Expand Up @@ -116,10 +120,6 @@ def _setupAsyncioRunner(self):
assert self._asyncioRunner is None, 'asyncio runner is already initialized'
runner = asyncio.Runner(debug=True)
self._asyncioRunner = runner
# Force loop to be initialized and set as the current loop
# so that setUp functions can use get_event_loop() and get the
# correct loop instance.
runner.get_loop()

def _tearDownAsyncioRunner(self):
runner = self._asyncioRunner
Expand Down