Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to Lifecycle of a Pull Request in CONTRIBUTING #98102

Merged
merged 2 commits into from
Oct 8, 2022

Conversation

jacobtylerwalls
Copy link
Contributor

The existing link to "Lifecycle of a Pull Request" was broken.

@ezio-melotti ezio-melotti merged commit 3378ebb into python:main Oct 8, 2022
@miss-islington
Copy link
Contributor

Thanks @jacobtylerwalls for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @jacobtylerwalls and @ezio-melotti, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 3378ebb933b00e1b95f1112511aa2cfb597a4ebf 3.11

@bedevere-bot
Copy link

GH-98106 is a backport of this pull request to the 3.10 branch.

@ezio-melotti ezio-melotti removed the needs backport to 3.11 only security fixes label Oct 8, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2022
* Fix link to Lifecycle of a Pull Request in CONTRIBUTING

* Remove trailing backslash.

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit 3378ebb)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@ezio-melotti ezio-melotti added the needs backport to 3.11 only security fixes label Oct 8, 2022
@miss-islington
Copy link
Contributor

Thanks @jacobtylerwalls for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-98107 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 8, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2022
* Fix link to Lifecycle of a Pull Request in CONTRIBUTING

* Remove trailing backslash.

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit 3378ebb)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
miss-islington added a commit that referenced this pull request Oct 8, 2022
* Fix link to Lifecycle of a Pull Request in CONTRIBUTING

* Remove trailing backslash.

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit 3378ebb)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
miss-islington added a commit that referenced this pull request Oct 8, 2022
* Fix link to Lifecycle of a Pull Request in CONTRIBUTING

* Remove trailing backslash.

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit 3378ebb)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
carljm added a commit to carljm/cpython that referenced this pull request Oct 9, 2022
* main:
  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)
  pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)
  Auto-cancel old builds when new commit pushed to branch (python#98009)
  pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
carljm added a commit to carljm/cpython that referenced this pull request Oct 9, 2022
* main: (5519 commits)
  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)
  pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)
  Auto-cancel old builds when new commit pushed to branch (python#98009)
  pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
  pythongh-68686: Retire eptag ptag scripts (python#98064)
  pythongh-97922: Run the GC only on eval breaker (python#97920)
  GitHub Workflows security hardening (python#96492)
  Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)
  pythongh-97913 Docs: Add walrus operator to the index (python#97921)
  [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)
  pythongh-97822: Fix http.server documentation reference to test() function (python#98027)
  pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)
  pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)
  pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)
  pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)
  pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)
  pythongh-57179: Add note on symlinks for os.walk (python#94799)
  pythongh-94808: Fix regex on exotic platforms (python#98036)
  pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)
  ...
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
* Fix link to Lifecycle of a Pull Request in CONTRIBUTING

* Remove trailing backslash.

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@jacobtylerwalls jacobtylerwalls deleted the fix-contributing-link branch January 16, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants