gh-94808: Cover PyFunction_GetCode, PyFunction_GetGlobals, PyFunction_GetModule
#98158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`PyFunction_GetModule`
sobolevn
commented
Oct 10, 2022
| { | ||
| PyObject *code = PyFunction_GetCode(func); | ||
| if (code != NULL) { | ||
| Py_INCREF(code); |
There was a problem hiding this comment.
Should this Py_INCREF be here? Shouldn't callee do this? 🤔
Without it I have this error:
test_function_get_module (test.test_capi.CAPITest.test_function_get_module) ... ok
----------------------------------------------------------------------
Ran 1 test in 0.001s
OK
== Tests result: SUCCESS ==
1 test OK.
Total duration: 242 ms
Tests result: SUCCESS
./Include/object.h:625: _Py_NegativeRefcount: Assertion failed: object has negative ref count
<object at 0x1082424d0 is freed>
Fatal Python error: _PyObject_AssertFailed: _PyObject_AssertFailed
Python runtime state: finalizing (tstate=0x000000010759c6d0)
Current thread 0x000000011215d5c0 (most recent call first):
<no Python frame>
[1] 92538 abort ./python.exe -m test -v test_capi -m test_function_get_module
There was a problem hiding this comment.
Cc: @markshannon as it pertains to code objects.
There was a problem hiding this comment.
I think this is correct, PyFunction_GetCode is documented as returning a borrowed ref: https://docs.python.org/3/c-api/function.html#c.PyFunction_GetCode
sobolevn
added
skip news
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
JelleZijlstra
approved these changes
Oct 15, 2022
|
Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Sorry, @sobolevn and @JelleZijlstra, I could not cleanly backport this to |
|
GH-98317 is a backport of this pull request to the 3.11 branch. |
JelleZijlstra
pushed a commit
to JelleZijlstra/cpython
that referenced
this pull request
Oct 16, 2022
…bals`, `PyFunction_GetModule` (pythonGH-98158). (cherry picked from commit 7b48d02) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Oct 17, 2022
* main: (31 commits) pythongh-95913: Move subinterpreter exper removal to 3.11 WhatsNew (pythonGH-98345) pythongh-95914: Add What's New item describing PEP 670 changes (python#98315) Remove unused arrange_output_buffer function from zlibmodule.c. (pythonGH-98358) pythongh-98174: Handle EPROTOTYPE under macOS in test_sendfile_fallback_close_peer_in_the_middle_of_receiving (python#98316) pythonGH-98327: Reduce scope of catch_warnings() in _make_subprocess_transport (python#98333) pythongh-93691: Compiler's code-gen passes location around instead of holding it on the global compiler state (pythonGH-98001) pythongh-97669: Create Tools/build/ directory (python#97963) pythongh-95534: Improve gzip reading speed by 10% (python#97664) pythongh-95913: Forward-port int/str security change to 3.11 What's New in main (python#98344) pythonGH-91415: Mention alphabetical sort ordering in the Sorting HOWTO (pythonGH-98336) pythongh-97930: Merge with importlib_resources 5.9 (pythonGH-97929) pythongh-85525: Remove extra row in doc (python#98337) pythongh-85299: Add note warning about entry point guard for asyncio example (python#93457) pythongh-97527: IDLE - fix buggy macosx patch (python#98313) pythongh-98307: Add docstring and documentation for SysLogHandler.createSocket (pythonGH-98319) pythongh-94808: Cover `PyFunction_GetCode`, `PyFunction_GetGlobals`, `PyFunction_GetModule` (python#98158) pythonGH-94597: Deprecate child watcher getters and setters (python#98215) pythongh-98254: Include stdlib module names in error messages for NameErrors (python#98255) Improve speed. Reduce auxiliary memory to 16.6% of the main array. (pythonGH-98294) [doc] Update logging cookbook with an example of custom handling of levels. (pythonGH-98290) ...
JelleZijlstra
added a commit
that referenced
this pull request
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the next PRs I will cover
PyFunction_*methods with setters.