Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-98713: Use @cpython_only for a test that fails on PyPy #98714

Merged
merged 3 commits into from
Oct 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Lib/test/test_typing.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
import weakref
import types

from test.support import import_helper, captured_stderr
from test.support import import_helper, captured_stderr, cpython_only
from test import mod_generics_cache
from test import _typed_dict_helper

Expand Down Expand Up @@ -4635,6 +4635,7 @@ def blah():

blah()

@cpython_only # gh-98713
def test_overload_on_compiled_functions(self):
with patch("typing._overload_registry",
defaultdict(lambda: defaultdict(dict))):
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix a bug in the :mod:`typing` tests where a test relying on CPython-specific
implementation details was not decorated with ``@cpython_only`` and was not
skipped on other implementations.