gh-98713: Use @cpython_only for a test that fails on PyPy
#98714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested review from
gvanrossum,
Fidget-Spinner,
JelleZijlstra and
AlexWaygood
as code owners
AlexWaygood
reviewed
Oct 26, 2022
|
I've never seen a NEWS entry for tests. If others say so - I surely will add it. |
|
We usually skip news for PRs that improve test coverage etc, but this is fixing a bug in the test suite that existed in a previous release of Python, so I'd argue for including a short news entry. |
AlexWaygood
approved these changes
Oct 26, 2022
Misc/NEWS.d/next/Tests/2022-10-26-15-19-20.gh-issue-98713.Lnu32R.rst
Outdated
Show resolved
Hide resolved
…2R.rst Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
kumaraditya303
approved these changes
Oct 26, 2022
|
@sobolevn: Status check is done, and it's a failure or timed out ❌. |
|
The |
|
Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-98717 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 26, 2022
…thonGH-98714) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> (cherry picked from commit 9495360) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington
added a commit
that referenced
this pull request
Oct 26, 2022
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> (cherry picked from commit 9495360) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typingtests:test_overload_on_compiled_functions()may not work on alternative Python implementations #98713Automerge-Triggered-By: GH:AlexWaygood