Skip to content

gh-98139: enhance namespace package repr #98870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2022
Merged

gh-98139: enhance namespace package repr #98870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64d592b
fix namespace repr; test simple repr
iyume Oct 30, 2022
d460db3
add NEWS because web tools 500
iyume Oct 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/importlib/_bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ def _module_repr_from_spec(spec):
if spec.loader is None:
return f'<module {name!r}>'
else:
return f'<module {name!r} ({spec.loader!r})>'
return f'<module {name!r} (namespace) from {list(spec.loader._path)}>'
else:
if spec.has_location:
return f'<module {name!r} from {spec.origin!r}>'
Expand Down
4 changes: 4 additions & 0 deletions Lib/test/test_importlib/test_namespace_pkgs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ def test_cant_import_other(self):
with self.assertRaises(ImportError):
import foo.two

def test_simple_repr(self):
import foo.one
assert repr(foo).startswith("<module 'foo' (namespace) from [")


class DynamicPathNamespacePackage(NamespacePackageTest):
paths = ['portion1']
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2022-10-30-15-26-33.gh-issue-98139.qtm-9T.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
In :mod:`importlib._bootstrap`, enhance namespace package repr to `<module
'x' (namespace) from ['path']>`.