Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-90716: Fix pylong_int_from_string() refleak #99094

Merged
merged 1 commit into from
Nov 4, 2022
Merged

gh-90716: Fix pylong_int_from_string() refleak #99094

merged 1 commit into from
Nov 4, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 4, 2022 •
edited by bedevere-bot
Loading

Fix validated by:

$ ./python -m test -R 3:3 test_int
Tests result: SUCCESS

@vstinner
gh-90716: Fix pylong_int_from_string() refleak
1cbba5c 
Fix validated by:

    $ ./python -m test -R 3:3 test_int
    Tests result: SUCCESS
@bedevere-bot bedevere-bot mentioned this pull request Nov 4, 2022
Open
@vstinner
Copy link
Member Author

vstinner commented Nov 4, 2022

cc @gpshead

kumaraditya303
kumaraditya303 approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit 387f725 into python:main Nov 4, 2022
@vstinner vstinner deleted the int_str branch November 4, 2022 13:24
@gpshead
Copy link
Member

gpshead commented Nov 4, 2022

Heh, thanks!

@vstinner
Copy link
Member Author

vstinner commented Nov 4, 2022

I wrote an article on this fix :-) https://vstinner.github.io/debug-python-refleak.html

Heh, thanks!

From what I understood, the refleak existed before 4c4b5ce. It's just that thanks to the added test, the Refleaks buildbot spotted the leak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @gpshead @kumaraditya303 @bedevere-bot