-
-
Notifications
You must be signed in to change notification settings - Fork 841
Document that bpo issues can be automatically closed using commit message #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Better follow what GitHub has: https://help.github.com/en/articles/closing-issues-using-keywords |
- include recent changes to bpo - clarify the downsides of GitHub
Reading bpo's source code, the magic words are matching this regex
|
@Mariatta, as per the below regex I understand that the matched words are -
One thing I wanted to point out from https://help.github.com/en/articles/closing-issues-using-keywords |
@rahul-kumi I think it's a great suggestion. I'm not actually involved in bpo development, so perhaps the bpo maintainers can give you better guidance on how to contribute there. From my perspective though, considering that we'll be migrating away to GitHub Issues, I think at this point it's not worth making such change to b.p.o. I do think it would still be great to document the existing behavior. |
Feature that was included in PEP-595 to automatically close issue in the bug tracker when a PR with commit message including words like- close, closes, closed, closing, fix, fixes or fixed being used with issue number is merged is documented in the devguide.
Since we migrated to GitHub, this can be closed. |
According to PEP 595, bpo now has a feature where issues can be automatically closed, if the PR commit message looks like
closes bpo-NNNN: ...
This should be documented in devguide and announced to core devs/core-workflow mailing list/discourse.
Some questions: what magic keywords accepted? "closes" "fixes" "close" "fix"?
Is it case sensitive? (I assume not)
Does it also update the "resolution" / "stage"?
The text was updated successfully, but these errors were encountered: