Skip to content

fixes #502: include infromation about auto-closure of bpo isssues #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kumiDa
Copy link
Contributor

@kumiDa kumiDa commented May 18, 2021

Fixes #502

Feature that was included in PEP-595 to automatically close issue
in the bug tracker when a PR with commit message including words like-
close, closes, closed, closing, fix, fixes or fixed being used with
issue number is merged is documented in the devguide.

Feature that was included in PEP-595 to automatically close issue
in the bug tracker when a PR with commit message including words like-
close, closes, closed, closing, fix, fixes or fixed being used with
issue number is merged is documented in the devguide.
@kumiDa
Copy link
Contributor Author

kumiDa commented May 3, 2022

@hugovk, the CLA is signed...still the CLA signing status is stated as expected.
Can you please help me with this.

@AlexWaygood AlexWaygood closed this May 3, 2022
@AlexWaygood AlexWaygood reopened this May 3, 2022
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still talks about bpo, which is no longer relevant.

Additionally, it would fit better at https://devguide.python.org/gitbootcamp/#accepting-and-merging-a-pr where we already talk about commit messages.

@ezio-melotti
Copy link
Member

Closing since we now migrated to GitHub.

@gvanrossum
Copy link
Member

But GitHub has a similar feature. Is that documented?

@ezio-melotti
Copy link
Member

Is that documented?

Apparently not.

Recently there was a discussion about the fact that using the auto-closing keywords is not always desirable, e.g.:

  • when the PR needs to be backported
  • when multiple PRs address the same issue

In these cases it might be better to avoid keywords and just close the issue manually once all the relevant PRs are merged. Both the keywords and recommendations on where they should be used/avoid can be documented.

I would really like to see sections with basic instructions/tips/reference for all the tools we use, but I'm still not sure what would be the best way to organize this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that bpo issues can be automatically closed using commit message
6 participants