Update instructions for building on macOS

[cesarcoatl]

1. Update the command for building Python 3.7 through 3.9 by exporting PKG_CONFIG_PATH so pkg-config can find tcl and tk
2. Instruct users on installing openssl with brew for building Python 3.10

Fixes: #1049

Signed-off-by: César Román thecesrom@gmail.com

[ghost]

All commit authors signed the Contributor License Agreement.

[CAM-Gerlach]

Standard reminder: You can directly apply all the suggestions you want in one go with Files changed -> Add to batch -> Commit

Some suggestions and questions to clarify the advice and the structure

[CAM-Gerlach]

(Standard reminder: You can directly apply all the suggestions you want in one go with Files changed -> Add to batch -> Commit)

[ned-deily]

Thanks for making the PR! If the 3.10+ PKG_CONFIG_PATH line is restored as I've commented in line, the Homebrew instructions seem to build as expected for 3.7 through current main/3.12 on a current macOS 13 system.

[CAM-Gerlach]

This looks good from my side, except that as mentioned previously, the immediately following introductory text (the last make step and the first line for MacPorts after it) should be updated to make sense with the changes here and ensure it is clearer for readers which instructions are specific to which distributor and Python version.

I can't make them as suggestions, but I can either just push a commit directly to your branch, or you can apply this diff:

``git diff`` output

diff --git a/getting-started/setup-building.rst b/getting-started/setup-building.rst
index b285a74..15e094a 100644
--- a/getting-started/setup-building.rst
+++ b/getting-started/setup-building.rst
@@ -419,7 +419,7 @@ For example, with **Homebrew**, install the dependencies::

     $ brew install pkg-config openssl@1.1 xz gdbm tcl-tk

-Then, for Python 3.10 and newer::
+Then, for Python 3.10 and newer, run ``configure``::

     $ CFLAGS="-I$(brew --prefix gdbm)/include -I$(brew --prefix xz)/include" \
       LDFLAGS="-L$(brew --prefix gdbm)/lib -I$(brew --prefix xz)/lib" \
@@ -438,11 +438,11 @@ Or, for Python 3.7 through 3.9::
               --with-tcltk-libs="$(pkg-config --libs tcl tk)" \
               --with-tcltk-includes="$(pkg-config --cflags tcl tk)"

-and ``make``::
+And finally, run ``make``::

     $ make -s -j2

-or **MacPorts**::
+Alternatively, with **MacPorts**::

     $ sudo port install pkgconfig openssl xz gdbm

Or am this patch:

``git format-patch`` output

From 8ae83afc0cbf616c1937408c8e5767ecd4625cf1 Mon Sep 17 00:00:00 2001
From: "C.A.M. Gerlach" <CAM.Gerlach@Gerlach.CAM>
Date: Wed, 15 Feb 2023 20:01:14 -0600
Subject: [PATCH] Update following text to match revised macOS building
 language

---
 getting-started/setup-building.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/getting-started/setup-building.rst b/getting-started/setup-building.rst
index b285a74..15e094a 100644
--- a/getting-started/setup-building.rst
+++ b/getting-started/setup-building.rst
@@ -419,7 +419,7 @@ For example, with **Homebrew**, install the dependencies::

     $ brew install pkg-config openssl@1.1 xz gdbm tcl-tk

-Then, for Python 3.10 and newer::
+Then, for Python 3.10 and newer, run ``configure``::

     $ CFLAGS="-I$(brew --prefix gdbm)/include -I$(brew --prefix xz)/include" \
       LDFLAGS="-L$(brew --prefix gdbm)/lib -I$(brew --prefix xz)/lib" \
@@ -438,11 +438,11 @@ Or, for Python 3.7 through 3.9::
               --with-tcltk-libs="$(pkg-config --libs tcl tk)" \
               --with-tcltk-includes="$(pkg-config --cflags tcl tk)"

-and ``make``::
+And finally, run ``make``::

     $ make -s -j2

-or **MacPorts**::
+Alternatively, with **MacPorts**::

     $ sudo port install pkgconfig openssl xz gdbm

--
2.37.1.windows.1

[cesarcoatl]

I'll work on that

[cesarcoatl]

@CAM-Gerlach patch has been applied

[pradyunsg]

Thanks @thecesrom!

PS: Merged this since OP has addressed all outstanding comments, the PR has an approval from the relevant expert, and changes look good to me!

[erlend-aasland]

Thanks for handling this CAM and Ned (and Pradyun for merging)!