Update location of the stable_abi.py script #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
reviewed
May 30, 2023
|
|
||
| - Build Python and check the using ``make check-limited-abi``. | ||
| On platforms without ``make``, run this command directly: | ||
|
|
||
| .. code-block:: shell | ||
|
|
||
| ./python ./Tools/scripts/stable_abi.py --all ./Misc/stable_abi.toml | ||
| ./python ./Tools/build/stable_abi.py --all ./Misc/stable_abi.toml |
There was a problem hiding this comment.
This one still fails on my machine with a fresh build of 3.12 FYI:
> python ./Tools/build/stable_abi.py --all ./Misc/stable_abi.toml
Running Debug|x64 interpreter...
Traceback (most recent call last):
File "C:\Users\alexw\coding\cpython\Tools\build\stable_abi.py", line 757, in <module>
main()
File "C:\Users\alexw\coding\cpython\Tools\build\stable_abi.py", line 723, in main
results['unixy_check'] = do_unixy_check(manifest, args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\alexw\coding\cpython\Tools\build\stable_abi.py", line 394, in do_unixy_check
present_macros = gcc_get_limited_api_macros(['Include/Python.h'])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\alexw\coding\cpython\Tools\build\stable_abi.py", line 526, in gcc_get_limited_api_macros
sysconfig.get_config_var("CC").split()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'split'
But at least the instructions now point to scripts that actually exist 😆
|
Whoa! I've meant to exclude that on Windows, but apparently I forgot! (un)fortunately there currently aren't any extra checks to run on Windows, so as a workaround, instead of
|
|
Issue: python/cpython#105091 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1102
📚 Documentation preview 📚: https://cpython-devguide--1103.org.readthedocs.build/