#116 (bpo-29563): update doc building section. #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezio-melotti
commented
Feb 23, 2017
| directory. | ||
| directory. Note that ``make check`` is automatically run when | ||
| you submit a :doc:`pull request <pullrequest>`, so you should make | ||
| sure that it runs without errors. |
There was a problem hiding this comment.
This doesn't actually seem to be the case for the devguide repo, so either the sentence should be removed or the check should be added.
There was a problem hiding this comment.
+1 on adding make check to the devguide repo.
There was a problem hiding this comment.
Where should we report this?
There was a problem hiding this comment.
I'd create a new issue at https://github.com/python/devguide/issues
berkerpeksag
approved these changes
Feb 23, 2017
| directory. | ||
| directory. Note that ``make check`` is automatically run when | ||
| you submit a :doc:`pull request <pullrequest>`, so you should make | ||
| sure that it runs without errors. |
There was a problem hiding this comment.
+1 on adding make check to the devguide repo.
Mariatta
approved these changes
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.