Handle NoReturn type aliases (#11912)

python · Jan 6, 2022 · ce42116 · ce42116
1 parent 37886c7
commit ce42116
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/mypy/semanal.py b/mypy/semanal.py
@@ -2247,6 +2247,12 @@ def is_type_ref(self, rv: Expression, bare: bool = False) -> bool:
                 return True
             # Assignment color = Color['RED'] defines a variable, not an alias.
             return not rv.node.is_enum
+        if isinstance(rv.node, Var):
+            return rv.node.fullname in (
+                'typing.NoReturn',
+                'typing_extensions.NoReturn',
+                'mypy_extensions.NoReturn',
+            )
 
         if isinstance(rv, NameExpr):
             n = self.lookup(rv.name, rv)

diff --git a/test-data/unit/check-type-aliases.test b/test-data/unit/check-type-aliases.test
@@ -50,6 +50,14 @@ def f(x: A) -> None:
 f(1)
 f('x')
 
+[case testNoReturnTypeAlias]
+# https://github.com/python/mypy/issues/11903
+from typing import NoReturn
+Never = NoReturn
+a: Never  # Used to be an error here
+
+def f(a: Never): ...
+f(5)  # E: Argument 1 to "f" has incompatible type "int"; expected "NoReturn" 
 [case testImportUnionAlias]
 import typing
 from _m import U