Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle NoReturn type aliases #11912

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Handle NoReturn type aliases #11912

merged 3 commits into from
Jan 6, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 5, 2022

Closes #11903

hauntsaninja
hauntsaninja approved these changes Jan 6, 2022
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
I added to the test case so we have some output / to make sure we don't have false negatives in the future.

@hauntsaninja hauntsaninja changed the title Handle NoReturn type alises Handle NoReturn type aliases Jan 6, 2022
@hauntsaninja hauntsaninja mentioned this pull request Jan 6, 2022
Closed
@hauntsaninja hauntsaninja merged commit ce42116 into python:master Jan 6, 2022
JukkaL pushed a commit that referenced this pull request Jan 6, 2022
@sobolevn @JukkaL
Handle NoReturn type aliases (#11912)
b40c3d0
tushar-deepsource pushed a commit to DeepSourceCorp/mypy that referenced this pull request Jan 20, 2022
@sobolevn @tushar-deepsource
Handle NoReturn type aliases (python#11912)
e13b9af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regression: type alias for NoReturn no longer works as a type annotation
2 participants
@sobolevn @hauntsaninja