-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(🎁) multiple platform/version compatible mode #12286
Comments
+1 To add a concrete example, I'm writing a library and I would really appreciate being able to test all these versions without (presumably -- I assume most work is duplicated but the caches are per python version, I believe?) taking 12x the time (windows, macos, linux * 3.8, 3.9, 3.10, 3.11). |
You can run them in parallel and it won't take 12x the time. If anything, doing it in one process will be slower because its python and the GIL exists. (By the way, this is how we did python2+3 at dropbox without taking 2x the time. Even daemon mode you can just have two daemons). |
@jhance |
One option could be to have an official/documented script in the mypy repo (and possibly installed with mypy) that does this -- run mypy in parallel (separate processes) using different options, making sure caches don't conflict, merge duplicate messages, etc. This would be fairly simple to implement and wouldn't complicate the maintenance of mypy itself. Anybody want to prototype this? The initial version could be a bit limited, and once it's in the repo, perhaps other contributors would help polish it! |
@JukkaL That sounds awesome! What is your opinion on upgrading the current analysis to incorporate the diverging paths of version/platform checks? As mentioned in the OP there would be additional benefits from it. |
I'm not Jukka, but that sounds like a big project. It means code throughout the whole type checker needs to have a concept of types that are different depending on the Python version. |
Also, different versions have different imports, different members in |
Another feature that this might be able to provide is the ability to use warn_unreachable & used ignores together in a multiplatform codebase. Simply placing a |
It seems to only check the true condition based on the given Python version in the config... See python/mypy#12286
It seems to only check the true condition based on the given Python version in the config... See python/mypy#12286
duplicates/extends #10747 |
If not supported natively, consider one option to combine with tox to run against multiple python versions. |
Feature
I want mypy to show errors for all platforms and versions, not just the current/selected one
actual:
Instead I have to run mypy many times to get a comprehensive output:
+ additional steps to curate the output into a readable format. (+ ratio?)
I would imagine that most libraries would want type checking applied for their supported python versions and platforms, and most python applications would probably want multiple platforms supported.
So almost everyone using mypy would want some level of cross support, and the current workaround includes manually building a solution involving running mypy concurrently and collecting / filtering the results. I would much rather this very common use-case be supported natively.
Perhaps some way of specifying a list of desired selections, and mypy could pass over the code with a matrix of those options. Perhaps mypy could run multiple processes to improve performance, or alternatively incorporate some complicated logic where it only does one run over the code but analyses the different paths/types correctly. The latter is the preferred solution in my mind, as it would be a lot more efficient and allow some additional benefits (#8823/#5940 comes to mind)
I would also expect mypy to show a note when an error is only detected under a diverging path, to make resolution easier.
pyproject.toml:
The text was updated successfully, but these errors were encountered: