Skip to content

Virtualenv install broken on Windows #4142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
emmatyping opened this issue Oct 20, 2017 · 0 comments
Closed

Virtualenv install broken on Windows #4142

emmatyping opened this issue Oct 20, 2017 · 0 comments
Labels
crash priority-0-high

Comments

@emmatyping
Copy link
Member

It seems that virtualenvs do not have a userbase prefix, so my recent changes in #4005 broke this. First reported here.
@emmatyping emmatyping mentioned this issue Oct 20, 2017
Closed
AleksanderGondek added a commit to AleksanderGondek/mypy that referenced this issue Oct 22, 2017
@AleksanderGondek
Fix broken installation on Windows in virtualenv
8ce93f7 
Fixes python#4142. Python `site.py` from any virtualenv does not contain many functions added in python 2.7 (see: pypa/virtualenv#355), which results in method `site.getsitepackages` being absent.

This commit replaces getsitepackages call with equivalent of `distutils.sysconfig.get_python_lib` which is supported in virtualenv.
AleksanderGondek added a commit to AleksanderGondek/mypy that referenced this issue Oct 22, 2017
@AleksanderGondek
Fix broken installation on Windows in virtualenv
6a52d4a 
Fixes python#4142. Python `site.py` from any virtualenv does not contain many functions added in python 2.7 (see: pypa/virtualenv#355), which results in method `site.getsitepackages` being absent.

This commit replaces getsitepackages call with equivalent of `distutils.sysconfig.get_python_lib` which is supported in virtualenv.
@AleksanderGondek AleksanderGondek mentioned this issue Oct 22, 2017
Merged
AleksanderGondek added a commit to AleksanderGondek/mypy that referenced this issue Oct 23, 2017
@AleksanderGondek
Fix broken installation on Windows in virtualenv
ed244b7 
Fixes python#4142. Python `site.py` from any virtualenv does not contain many functions added in python 2.7 (see: pypa/virtualenv#355), which results in method `site.getsitepackages` being absent.

This commit replaces getsitepackages call with equivalent of `distutils.sysconfig.get_python_lib` which is supported in virtualenv.
ilevkivskyi pushed a commit that referenced this issue Oct 25, 2017
@AleksanderGondek @ilevkivskyi
Fix broken installation on Windows in virtualenv (#4149)
4a10e05 
Fixes #4142. Python `site.py` from any virtualenv does not contain
many functions added in python 2.7
(see: pypa/virtualenv#355), which results in
method `site.getsitepackages` being absent.

This commit replaces getsitepackages call with equivalent of
`distutils.sysconfig.get_python_lib` which is supported in virtualenv.
JukkaL pushed a commit that referenced this issue Oct 31, 2017
@AleksanderGondek @JukkaL
Fix broken installation on Windows in virtualenv (#4149)
605ced1 
Fixes #4142. Python `site.py` from any virtualenv does not contain
many functions added in python 2.7
(see: pypa/virtualenv#355), which results in
method `site.getsitepackages` being absent.

This commit replaces getsitepackages call with equivalent of
`distutils.sysconfig.get_python_lib` which is supported in virtualenv.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crash priority-0-high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emmatyping