Support user install on Windows. #4005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, the usual install paths are sys.prefix/Lib/mypy for a global install. For user installs, the path is site.getuserbase()/lib/mypy. We also fall back to the old method of installation due to the data dir being put in the package directory on an egg install.
gvanrossum
requested changes
Sep 25, 2017
|
Removed. Mypy wasn't happy with the map call either. |
gvanrossum
approved these changes
Sep 25, 2017
|
The Appveyor failure was the usual #3895 |
ilevkivskyi
approved these changes
Sep 25, 2017
gvanrossum
approved these changes
Sep 25, 2017
|
Seems like it fixed the issue I was having, works for me! |
|
Be aware that this change as shipped in 0.530 (installed from pypi) breaks when run under virtualenv on Windows. The underlying reason is that - for reasons I don't understand - virtualenv overwrites Lib/site.py with an old version which does not include the function site.getuserbase(). Would a direct call to sysconfig.get_config_var('userbase') be a suitable workaround? |
|
@davt Can you file a new issue for the virtualenv-on-Windows problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the usual install paths are
sys.prefix/Lib/mypyfor a globalinstall. For user installs, the path is
site.getuserbase()/lib/mypy. Wealso fall back to the old method of installation due to the data dir being
put in the package directory on an egg install.
This restores the usual data directory resolution on other platforms.
Correctly fixes #3988, and keeps other platforms working.