Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python 2 logic from checkexpr #13264

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Remove Python 2 logic from checkexpr #13264

merged 3 commits into from
Jul 28, 2022

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Jul 28, 2022 •
edited
Loading

Linking #12237

@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood reviewed Jul 28, 2022
View reviewed changes
mypy/checkexpr.py Outdated Show resolved Hide resolved
sobolevn
sobolevn reviewed Jul 28, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a left-over: operators.comparison_fallback_method is not used anywhere else.

@sobolevn sobolevn mentioned this pull request Jul 28, 2022
Merged
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja hauntsaninja merged commit 222ac7b into python:master Jul 28, 2022
@hauntsaninja hauntsaninja deleted the py2-checkexpr branch July 28, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@sobolevn sobolevn sobolevn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hauntsaninja @sobolevn @AlexWaygood