Remove all builtins.unicode references
#13272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ilevkivskyi
reviewed
Jul 28, 2022
mypy/fastparse.py
Outdated
| # If we're analyzing Python 3, that function will translate 'builtins.unicode' | ||
| # into 'builtins.str'. In contrast, if we're analyzing Python 2 code, we'll | ||
| # translate 'builtins.bytes' in the method below into 'builtins.str'. | ||
|
|
||
| # Do a getattr because the field doesn't exist in 3.8 (where | ||
| # this method doesn't actually ever run.) We can't just do | ||
| # an attribute access with a `# type: ignore` because it would be | ||
| # unused on < 3.8. | ||
| kind: str = getattr(n, "kind") # noqa |
ilevkivskyi
reviewed
Jul 28, 2022
| @@ -401,12 +401,6 @@ def get_default_arg_types(self, fdef: FuncDef) -> List[Optional[Type]]: | |||
| for arg in fdef.arguments | |||
| ] | |||
|
|
|||
| def add_adjustments(self, typs: List[Type]) -> List[Type]: | |||
| if not self.try_text or self.manager.options.python_version[0] != 2: | |||
There was a problem hiding this comment.
It looks like whole --try-text argument (Try using unicode wherever str is inferred, according to help) is not very useful now. So can probably be deleted (together with tests).
|
Thanks, great points! Removed. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
ilevkivskyi
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #12237
Should be merged after #13264 since
checkexpris usingunicodeas well.