Give arguments a more reasonable location #14562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies arguments parsed from the AST to use the AST's row and column information. Modifies function definitions to not overwrite their arguments' locations. Modifies incorrect override messages to use the locations of arguments instead of the method itself. Modifies tests to expect the new locations.
This comment has been minimized.
This comment has been minimized.
- Only fetch python AST's end column and line when available - Move type-ignore to the line with an argument - Update python-slow test case to use location of argument
|
This might have to include some flag to use the old behavior, or to try to detect type: ignore at the old location, since it'll break existing users otherwise. |
This comment has been minimized.
This comment has been minimized.
I like the idea of detecting a type: ignore at the old location, if it's not hard to implement. Otherwise we'll need two feature releases before we can enable this by default (as it breaks backward compatibility), and it will cause some friction for users. |
Add another context to this message reporting. This means that we'll now check both contexts when looking at what errors to ignore.
koogoro
force-pushed
the
maxmurin/better-location-for-incompatibility-error
branch
from
4d0993a
to
6e325ee
Compare
|
Diff from mypy_primer, showing the effect of this PR on open source code: pip (https://github.com/pypa/pip)
- src/pip/_internal/network/xmlrpc.py:32: error: Argument 3 of "request" is incompatible with supertype "Transport"; supertype defines the argument type as "Union[bytes, Union[bytearray, memoryview, array[Any], mmap, _CData, PickleBuffer]]" [override]
+ src/pip/_internal/network/xmlrpc.py:36: error: Argument 3 of "request" is incompatible with supertype "Transport"; supertype defines the argument type as "Union[bytes, Union[bytearray, memoryview, array[Any], mmap, _CData, PickleBuffer]]" [override]
- src/pip/_internal/network/xmlrpc.py:32: note: This violates the Liskov substitution principle
+ src/pip/_internal/network/xmlrpc.py:36: note: This violates the Liskov substitution principle
- src/pip/_internal/network/xmlrpc.py:32: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
+ src/pip/_internal/network/xmlrpc.py:36: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
operator (https://github.com/canonical/operator)
- ops/framework.py:688: error: Name "kind" already defined on line 679 [no-redef]
+ ops/framework.py:688: error: Name "kind" already defined on line 680 [no-redef]
- ops/charm.py:1086: error: Name "raw" already defined on line 1082 [no-redef]
+ ops/charm.py:1086: error: Name "raw" already defined on line 1083 [no-redef]
- ops/charm.py:1087: error: Name "actions_raw" already defined on line 1082 [no-redef]
+ ops/charm.py:1087: error: Name "actions_raw" already defined on line 1084 [no-redef]
SinbadCogs (https://github.com/mikeshardmind/SinbadCogs)
- rolemanagement/utils.py:57: error: Argument 2 of "update_roles_atomically" is incompatible with supertype "MixinMeta"; supertype defines the argument type as "Optional[List[Any]]" [override]
+ rolemanagement/utils.py:61: error: Argument 2 of "update_roles_atomically" is incompatible with supertype "MixinMeta"; supertype defines the argument type as "Optional[List[Any]]" [override]
- rolemanagement/utils.py:57: note: This violates the Liskov substitution principle
+ rolemanagement/utils.py:61: note: This violates the Liskov substitution principle
- rolemanagement/utils.py:57: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
+ rolemanagement/utils.py:61: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
- rolemanagement/utils.py:57: error: Argument 3 of "update_roles_atomically" is incompatible with supertype "MixinMeta"; supertype defines the argument type as "Optional[List[Any]]" [override]
+ rolemanagement/utils.py:62: error: Argument 3 of "update_roles_atomically" is incompatible with supertype "MixinMeta"; supertype defines the argument type as "Optional[List[Any]]" [override]
+ rolemanagement/utils.py:62: note: This violates the Liskov substitution principle
+ rolemanagement/utils.py:62: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
ibis (https://github.com/ibis-project/ibis)
- ibis/backends/duckdb/__init__.py:276: error: Argument 1 of "read_csv" is incompatible with supertype "_FileIOHandler"; supertype defines the argument type as "Union[str, Path]" [override]
+ ibis/backends/duckdb/__init__.py:278: error: Argument 1 of "read_csv" is incompatible with supertype "_FileIOHandler"; supertype defines the argument type as "Union[str, Path]" [override]
- ibis/backends/duckdb/__init__.py:276: note: This violates the Liskov substitution principle
+ ibis/backends/duckdb/__init__.py:278: note: This violates the Liskov substitution principle
- ibis/backends/duckdb/__init__.py:276: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
+ ibis/backends/duckdb/__init__.py:278: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
- ibis/backends/duckdb/__init__.py:320: error: Argument 1 of "read_parquet" is incompatible with supertype "_FileIOHandler"; supertype defines the argument type as "Union[str, Path]" [override]
+ ibis/backends/duckdb/__init__.py:322: error: Argument 1 of "read_parquet" is incompatible with supertype "_FileIOHandler"; supertype defines the argument type as "Union[str, Path]" [override]
- ibis/backends/duckdb/__init__.py:320: note: This violates the Liskov substitution principle
+ ibis/backends/duckdb/__init__.py:322: note: This violates the Liskov substitution principle
- ibis/backends/duckdb/__init__.py:320: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
+ ibis/backends/duckdb/__init__.py:322: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
|
|
Looks like the primer is only detecting changed line numbers now, which is desirable. |
JukkaL
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies arguments parsed from the AST to use the AST's row and column information. Modifies function definitions to not overwrite their arguments' locations. Modifies incorrect override messages to use the locations of arguments instead of the method itself. Modifies tests to expect the new locations.
I'm not sure whether this handles bound arguments correctly; it passes tests but I don't know whether there's some edge case I'm missing.
Fixes #8298.