Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give arguments a more reasonable location #14562

Commits on Jan 30, 2023

  1. Give arguments a more reasonable location

    Modifies arguments parsed from the AST to use the AST's row and
    column information. Modifies function definitions to not overwrite
    their arguments' locations. Modifies incorrect override messages to
    use the locations of arguments instead of the method itself.
    Modifies tests to expect the new locations.
    koogoro committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    1b607e4 View commit details
    Browse the repository at this point in the history
  2. Fix pre-3.8 AST, self-ignore annotation, pytest-slow test case

    - Only fetch python AST's end column and line when available
    - Move type-ignore to the line with an argument
    - Update python-slow test case to use location of argument
    koogoro committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    7a3d4ab View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. Add a secondary context for this error message

    Add another context to this message reporting. This means that we'll now check both contexts when looking at what errors to ignore.
    koogoro committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    6e325ee View commit details
    Browse the repository at this point in the history