Consistent quote wrapping around MessageBuilder.format as per issue #3409 #3430

mistermocha · 2017-05-23T22:02:56Z

Tidying up inconsistent quotes around returned types for formatting. See #3409 for background.

This was something I was looking for in the quick start, and didn't find clearly stated anywhere in the README.

Fixes python#3308 This PR adds better processing of "synthetic" types (``NewType``, ``NamedTuple``, ``TypedDict``) to the third pass and moves some processing from the second to the third pass.

* Add note for diff inffered and return type * Fix conditions for note * Move tests to newline * Style improvements and more detailed message * Fix tests * Move message function to messages * More test cases * Test different sequence * Cleaner separate of test cases

* Add type checking plugin support for functions The plugins allow implementing special-case logic for inferring the return type of certain functions with tricky signatures such as `open` in Python 3. Include plugins for `open` and `contextlib.contextmanager`. Some design considerations: - The plugins have direct access to mypy internals. The idea is that most plugins will be included with mypy so mypy maintainers can update the plugins as needed. - User-maintained plugins are currently not supported but could be added in the future. However, the intention is to not have a stable plugin API, at least initially. User-maintained plugins would have to track mypy internal API changes. Later on, we may decide to provide a more stable API if there seems to be a significant need. The preferred way would still be to keep plugins in the mypy repo. * Add test case for additional special cases * Fix handling of arguments other than simple positional ones Also add comments and some defensive checks.

…tional (python#3248) See python/typing#275.

Fix python#3393 This results in pytest output being shown as a passthrough at the beginning of runtests.py.

…ne (python#3466)

…#3447) Fixes python#2775

This will allow the links in python#3411 to be shorter.

Use entry_points instead of custom scripts (but custom scripts remain in case they are still useful).

Use case: type hierarchy of IDs, all of which are integers at runtime, but we want to type-check distinctions between e.g. "id of User" and "id of Media", while still allowing some functions to take "any ID" (which is still a more specific type than "any integer").

Fixes python#3442.

gvanrossum

Thanks for powering through all the tests! Just two tiny nits.

gvanrossum · 2017-05-29T03:09:56Z

mypy/messages.py

@@ -241,6 +241,12 @@ def format_simple(self, typ: Type, verbosity: int = 0) -> str:
          None -> None
          callable type -> "" (empty string)
        """
+        ret = self._format_simple(typ, verbosity)
+        if ret == "Module":


Should really use 'Module' here. (Also I really detest the messages "Module does not blah" -- I always need to know the module name. But that's a separate concern.)

Clarify... are you suggesting single quotes over double quotes?

Only one this one line in the source code. (In the output I am fine with the double quotes.) But the line of code that generates the special value 'Modules' also uses single quotes, as does most of the surrounding code, so I'd like this line to be consistent.

gvanrossum · 2017-05-29T03:11:20Z

mypy/messages.py

                if len(s) < 400:
                    return s
                else:
                    return 'union type ({} items)'.format(len(items))
        elif isinstance(typ, NoneTyp):
            return 'None'
        elif isinstance(typ, AnyType):
-            return '"Any"'
+            return 'Any'
        elif isinstance(typ, DeletedType):
            return '<deleted>'


Hm, I think it would look ugly to have "<deleted>" in the error messages, and ditto for "<nothing>" below. Maybe the code that adds the quotes should make an exception for strings starting with < and ending with >.

<deleted> was not part of this diff. Can we bump to another? This one is already a behemoth of test changes.

But IIUC this diff would change <deleted> into "<deleted>" which I think is wrong. So it's part of the diff. And there seem to be no tests with <deleted> so there's no extra burden there. (Similar for <nothing>.)

gvanrossum · 2017-05-29T03:15:11Z

PS. Who's Brian Weber (bweber@twitter.com)? The commits are by him but the PR is by mistermocha. Are you the same person?

gvanrossum · 2017-05-29T03:15:29Z

Also please resolve the merge conflict.

This gets rid of code duplication and makes sure mypy works with the released version of `typing`. This doesn't fix any immediate issue, but I saw some comments in the bug tracker saying that we should be able to get rid of `lib-typing` eventually. There is a minor downside: To run mypy tests locally, you will now have to have a Python 2.7 installed that has `typing` available.

…ython#3409

mistermocha · 2017-05-29T07:07:43Z

Yes, I'm bweber@twitter.com as well as this account for @mistermocha. I have been working off of my work laptop for sprints. so my ~/.gitconfig has my work email.

Test conflicts galore. After a pull/rebase/merge-conflict-resolve, I updated test data and got this:

Expected:
  ok                                            (diff)
Actual:
  Traceback (most recent call last):            (diff)
    File "_testPrintFunctionWithFileArg_python2.py", line 2, in <module> (diff)
      import typing                             (diff)
  ImportError: No module named typing           (diff)

... mutiple times. This doesn't seem right.

emmatyping · 2017-05-29T10:28:06Z

After recent commits you need to install typing for Python 2 on your machine.

gvanrossum · 2017-05-30T04:00:43Z

Yes, I'm bweber@twitter.com as well as this account for @mistermocha.

Since you've now been outed you might as well update the full name and email on the GitHub account (AFAIK GitHub lets you register multiple email addresses).

gvanrossum · 2017-05-30T21:15:56Z

I don't know what you did, but you now have a bunch of unrelated commits in this PR. I expect you can fix that using rebase (but I don't know your setup so I can't give you more specific advice).

gvanrossum · 2017-06-09T23:48:59Z

Blocked until that can be fixed.

Possibly you could save your diffs in an old-fashioned patch file outside your repo, get rid of your clone, get rid of the fork, create a new fork, clone that, and re-apply your patches using git patch. Depending on your network bandwidth that might be quicker than trying to recover...

ilevkivskyi · 2017-08-22T20:44:21Z

@mistermocha are you still working on this? this would help other PRs.

mistermocha · 2017-08-22T21:08:40Z

Apologies, I've been tied up. I'll likely have time this weekend to wrap up. If anyone has bandwidth to take over, I'm happy to hand off.

…

On Tue, Aug 22, 2017 at 1:44 PM, Ivan Levkivskyi ***@***.***> wrote: @mistermocha <https://github.com/mistermocha> are you still working on this? this would help other PRs. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3430 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADnoGdPrDV-1hLHZv9lMzIpZqTr72PYUks5saz2pgaJpZM4NkWAi> .

OddBloke · 2017-08-25T10:17:54Z

I've been taking a look at this, and I've resolved most of the conflicts. Will push up a branch later today.

OddBloke · 2017-08-25T11:06:50Z

That branch is pushed and I've proposed it for merge at #3873.

ilevkivskyi · 2017-08-25T12:48:27Z

OK, I am closing this in favor of #3873

ilevkivskyi · 2017-08-25T12:49:16Z

@mistermocha Thanks for your efforts! This PR was very helpful as a starting point.

mistermocha · 2017-08-25T14:59:23Z

Well done! Happy to help!

…

On Aug 25, 2017 5:49 AM, "Ivan Levkivskyi" ***@***.***> wrote: @mistermocha <https://github.com/mistermocha> Thanks for your efforts! This PR was very helpful as a starting point. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3430 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADnoGQ4vIeP_JzkpPCjjgm2wlTIYPMWOks5sbsLQgaJpZM4NkWAi> .

@mistermocha

This is a refreshed version of #3430 (credits @mistermocha). Fixes #3409. Tidying up inconsistent quotes around returned types for formatting. See #3409 for background.

Brian Weber and others added 20 commits May 23, 2017 15:01

Consistent quote wrapping around MessageBuilder.format as per issue p…

b4b7de9

…ython#3409

No quotes around Module

466a832

And even more tests that need to be updated

dc7c243

incorrect indentation

df58633

Add 'how to run this one test' note to test quick start. (python#3436)

7940d76

This was something I was looking for in the quick start, and didn't find clearly stated anywhere in the README.

Fix crashes in synthetic types (python#3322)

ccd95e6

Fixes python#3308 This PR adds better processing of "synthetic" types (``NewType``, ``NamedTuple``, ``TypedDict``) to the third pass and moves some processing from the second to the third pass.

Fix bug in cache log (python#3443)

75c526a

Sync typeshed (python#3449)

847d884

Add flag to avoid interpreting arguments with a default of None as Op…

443c479

…tional (python#3248) See python/typing#275.

Add mypy roadmap (python#3460)

577dd99

Print pytest output as it happens (python#3463)

3ba42e8

Fix python#3393 This results in pytest output being shown as a passthrough at the beginning of runtests.py.

Fix last character cut in html-report if file does not end with newli…

278a10a

…ne (python#3466)

Better error message for invalid package names passed to mypy (python…

4d61418

…#3447) Fixes python#2775

Change label for variance section to just 'variance' (python#3429)

c0f7bba

This will allow the links in python#3411 to be shorter.

Fix 'variance' label.

99f372e

Add console scripts (python#3074)

166d54d

Use entry_points instead of custom scripts (but custom scripts remain in case they are still useful).

Fix None slice bounds with strict-optional (python#3445)

9ec8a95

Fixes python#3442.

gvanrossum requested changes May 29, 2017

View reviewed changes

gvanrossum self-assigned this May 29, 2017

gvanrossum and others added 6 commits May 28, 2017 20:17

Move version of extensions to post-release (python#3348)

e1fcab8

Consistent quote wrapping around MessageBuilder.format as per issue p…

ba55b1a

…ython#3409

No quotes around Module

e134f8f

And even more tests that need to be updated

60231de

incorrect indentation

735778e

Brian Weber added 2 commits May 30, 2017 11:41

update tests & merge conflicts

5922be3

and even more merge conflicts

b349b8e

ilevkivskyi mentioned this pull request Jun 5, 2017

[WIP] Fix crash when joining tuple and NamedTuple #3129

Closed

gvanrossum added the blocked label Jun 9, 2017

ilevkivskyi mentioned this pull request Jul 27, 2017

Incompatible return type error doesn't quote types #3771

Closed

OddBloke mentioned this pull request Aug 22, 2017

MessageBuilder.format_distinctly doesn't make identically named (but different) types distinct when one is generic #3860

Open

OddBloke mentioned this pull request Aug 25, 2017

Consistent quote wrapping around MessageBuilder.format #3873

Merged

ilevkivskyi closed this Aug 25, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consistent quote wrapping around MessageBuilder.format as per issue #3409 #3430

Consistent quote wrapping around MessageBuilder.format as per issue #3409 #3430

mistermocha commented May 23, 2017

gvanrossum left a comment

gvanrossum May 29, 2017

mistermocha May 29, 2017

gvanrossum May 30, 2017

gvanrossum May 29, 2017

mistermocha May 29, 2017

gvanrossum May 30, 2017

gvanrossum commented May 29, 2017

gvanrossum commented May 29, 2017

mistermocha commented May 29, 2017

emmatyping commented May 29, 2017

gvanrossum commented May 30, 2017

gvanrossum commented May 30, 2017

gvanrossum commented Jun 9, 2017

ilevkivskyi commented Aug 22, 2017

mistermocha commented Aug 22, 2017 via email

OddBloke commented Aug 25, 2017

OddBloke commented Aug 25, 2017

ilevkivskyi commented Aug 25, 2017

ilevkivskyi commented Aug 25, 2017

mistermocha commented Aug 25, 2017 via email

Consistent quote wrapping around MessageBuilder.format as per issue #3409 #3430

Consistent quote wrapping around MessageBuilder.format as per issue #3409 #3430

Conversation

mistermocha commented May 23, 2017

gvanrossum left a comment

Choose a reason for hiding this comment

gvanrossum May 29, 2017

Choose a reason for hiding this comment

mistermocha May 29, 2017

Choose a reason for hiding this comment

gvanrossum May 30, 2017

Choose a reason for hiding this comment

gvanrossum May 29, 2017

Choose a reason for hiding this comment

mistermocha May 29, 2017

Choose a reason for hiding this comment

gvanrossum May 30, 2017

Choose a reason for hiding this comment

gvanrossum commented May 29, 2017

gvanrossum commented May 29, 2017

mistermocha commented May 29, 2017

emmatyping commented May 29, 2017

gvanrossum commented May 30, 2017

gvanrossum commented May 30, 2017

gvanrossum commented Jun 9, 2017

ilevkivskyi commented Aug 22, 2017

mistermocha commented Aug 22, 2017 via email

OddBloke commented Aug 25, 2017

OddBloke commented Aug 25, 2017

ilevkivskyi commented Aug 25, 2017

ilevkivskyi commented Aug 25, 2017

mistermocha commented Aug 25, 2017 via email