Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stubgen: Added basic support for importing modules that base classes are a member of #3704

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions mypy/stubgen.py
Original file line number Diff line number Diff line change
Expand Up @@ -347,9 +347,7 @@ def get_base_types(self, cdef: ClassDef) -> List[str]:
if base.name != 'object':
base_types.append(base.name)
elif isinstance(base, MemberExpr):
modname = get_qualified_name(base.expr)
base_types.append('%s.%s' % (modname, base.name))
self.add_import_line('import %s\n' % modname)
base_types.append(get_qualified_name(base))
return base_types

def visit_assignment_stmt(self, o: AssignmentStmt) -> None:
Expand Down Expand Up @@ -437,8 +435,9 @@ def visit_import_from(self, o: ImportFrom) -> None:
exported_names.update(sub_names)
self.import_and_export_names(o.id, o.relative, sub_names)
# Import names used as base classes.
base_class_imports = [base_class.split('.')[0] for base_class in self._base_classes]
base_names = [(name, alias) for name, alias in o.names
if alias or name in self._base_classes and name not in exported_names]
if alias or name in base_class_imports and name not in exported_names]
if base_names:
imp_names = [] # type: List[str]
for name, alias in base_names:
Expand Down Expand Up @@ -468,6 +467,12 @@ def visit_import(self, o: Import) -> None:
'.' not in id):
self.add_import_line('import %s as %s\n' % (id, target_name))
self.record_name(target_name)
base_class_imports = [base_class.split('.')[0] for base_class in self._base_classes]
if target_name in base_class_imports:
if as_id:
self.add_import_line('import %s as %s\n' % (id, as_id))
else:
self.add_import_line('import %s\n' % (id, ))

def get_init(self, lvalue: str, rvalue: Expression) -> Optional[str]:
"""Return initializer for a variable.
Expand Down
26 changes: 26 additions & 0 deletions test-data/unit/stubgen.test
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,14 @@ import x.y

class D(x.y.C): ...

[case testArbitraryBaseClassWithAlias]
import x as y
class D(y.C): ...
[out]
import x as y

class D(y.C): ...

[case testUnqualifiedArbitraryBaseClassWithNoDef]
class A(int): ...
[out]
Expand Down Expand Up @@ -628,5 +636,23 @@ class A:
x = ... # type: Any
def __init__(self, a: Optional[Any] = ...) -> None: ...

[case testImportAddedForQualifiedBaseClass]
from foo import bar

class A(bar.fuzz.Baz): ...
[out]
from foo import bar

class A(bar.fuzz.Baz): ...

[case testImportAddedForQualifiedBaseClassWithAlias]
from foo import bar as baz

class A(baz.Baz): ...
[out]
from foo import bar as baz

class A(baz.Baz): ...

-- More features/fixes:
-- do not export deleted names