Stubgen: Added basic support for importing modules that base classes are a member of #3704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangxiao
changed the title
shangxiao
force-pushed
the
resolve-imports
branch
from
a000ac8 to
31b23ea
Compare
|
Sorry, we're busy reviewing, we'll get to this when we can. |
|
No rush was just curious. |
shangxiao
changed the title
|
I am closing this in favor of recently merged PR #3169 that also fixes this problem. @rapilabs I am sorry to close this, and thank you for your help anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1782
I've taken the liberty of adding a very basic check to match imports with qualified base classes and adding those to the list of imports to be added to the stub.
Disclaimer: I wouldn't consider myself a Python expert. I'm not sure I've seen any other way to declare or reassign imports that would break this check so I wouldn't know if there was any extra processing required here. :)