add "type: ignore" to lxml imports #4217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See python/typeshed#525 and python/typeshed#1664. We decided to remove the lxml stubs because they cause problems so frequently. However, this requires small tweaks to mypy's own usage of lxml. My plan is to proceed as follows: - Merge this PR, adding type ignores and removing warn_unused_ignores from mypy's self-check config. - Merge python/typeshed#1664, which should pass Travis after his PR is merged. - Add "warn_unused_ignores" back to mypy's self-check config. I confirmed that this PR passes tests both with and without the lxml stubs being present.
Closed
JelleZijlstra
added a commit
that referenced
this pull request
Nov 7, 2017
Followup from #4217 and python/typeshed#1664.
JelleZijlstra
added a commit
that referenced
this pull request
Nov 7, 2017
Followup from #4217 and python/typeshed#1664.
gvanrossum
pushed a commit
that referenced
this pull request
Nov 7, 2017
Followup from #4217 and python/typeshed#1664. Also had to change a few types to `Any` because of the missing lxml stubs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See python/typeshed#525 and python/typeshed#1664.
We decided to remove the lxml stubs because they cause problems so
frequently. However, this requires small tweaks to mypy's own usage
of lxml.
My plan is to proceed as follows:
from mypy's self-check config.
is merged.
I confirmed that this PR passes tests both with and without the
lxml stubs being present.