Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial Datastructures Review. #148

Merged
merged 2 commits into from
Feb 6, 2018

Conversation

christopheNan
Copy link
Contributor

No description provided.

Copy link
Member

@JulienPalard JulienPalard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review but I spotted a few changes in msgid.

"insert(len(a), x)`` est équivalent à ``a.append(x)``."

#: ../Doc/tutorial/datastructures.rst:43
msgid ""
"Remove the first item from the list whose value is *x*. It is an error if "
"there is no such item."
"Remove the first item from the list whose value is equal to *x*. It is an "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the msgid changed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne sais pas ! j'ai "joué" avec make merge et git pull dans cpython. J'essaie de reproduire...


#: ../Doc/tutorial/datastructures.rst:66
msgid ""
"Return zero-based index in the list of the first item whose value is *x*. "
"Raises a :exc:`ValueError` if there is no such item."
"Return zero-based index in the list of the first item whose value is equal "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@JulienPalard JulienPalard merged commit d71a11b into python:3.6 Feb 6, 2018
@christopheNan christopheNan deleted the tutorialdatastruct branch February 7, 2018 10:20
JulienPalard pushed a commit that referenced this pull request May 24, 2023
Within using/unix:
* Remove an obsolete fuzzy entry already updated by 26c991f
* translate [63e127f33d4088e28a470a1db98623d46e59a46a](python/cpython#94076): fix broken link
* translate [3ddf3972173bfee557af01680647dca9701bde54](python/cpython#102727): envvar->option: {exec_,}prefix

Co-authored-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@ir5.eu>
Reviewed-on: https://git.afpy.org/AFPy/python-docs-fr/pulls/148
Reviewed-by: Julien Palard <julien@palard.fr>
Co-authored-by: pilou <pierre-louis.bonicoli@libregerbil.fr>
Co-committed-by: pilou <pierre-louis.bonicoli@libregerbil.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants