Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.10.0.1 breaks CI in importlib_metadata #865

Closed
jaraco opened this issue Aug 29, 2021 · 13 comments
Closed

3.10.0.1 breaks CI in importlib_metadata #865

jaraco opened this issue Aug 29, 2021 · 13 comments

Comments

@jaraco
Copy link
Member

jaraco commented Aug 29, 2021

In python/importlib_metadata#350, I observed that the tests on Python 3.10 started failing. Looking at a diff of the dependencies, I can see that the issue is brought about by the introduction of the recently released typing-extensions==3.10.0.1.

Error message is:

    class _ConcatenateGenericAlias(list):
    
        # Trick Generic into looking into this for __parameters__.
        if PEP_560:
>           __class__ = _GenericAlias
E           NameError: name '_GenericAlias' is not defined

.tox/python/lib/python3.10/site-packages/typing_extensions.py:2394: NameError

I suspect this issue will have widespread impact on environments running under Python 3.10.

jaraco added a commit to python/importlib_metadata that referenced this issue Aug 29, 2021
jaraco added a commit to python/importlib_metadata that referenced this issue Aug 29, 2021
jaraco added a commit to python/importlib_metadata that referenced this issue Aug 29, 2021
@JelleZijlstra
Copy link
Member

Thanks for bringing this up! I can release a new version as soon as this is fixed, but we should probably get CI back up first (#864).

Zac-HD added a commit to Zac-HD/hypothesis that referenced this issue Aug 30, 2021
python/typing#865 - CI fails under Python 3.10
davfsa added a commit to hikari-py/hikari that referenced this issue Aug 30, 2021
Zac-HD added a commit to honno/hypothesis that referenced this issue Aug 30, 2021
python/typing#865 - CI fails under Python 3.10
beniwohli added a commit to beniwohli/apm-agent-python that referenced this issue Aug 30, 2021
That specific version has a bug on Python 3.10

See python/typing#865
beniwohli added a commit to elastic/apm-agent-python that referenced this issue Aug 30, 2021
That specific version has a bug on Python 3.10

See python/typing#865
BvB93 pushed a commit to BvB93/numpy that referenced this issue Aug 30, 2021
sqlalchemy-bot pushed a commit to sqlalchemy/sqlalchemy that referenced this issue Aug 30, 2021
Change-Id: I7b35bc86a7b78f96d8006515341f7cc7a6b49dcc
References: python/typing#865
@Fidget-Spinner
Copy link
Member

@jaraco thanks for highlighting this to us and sorry about that. I'll try to fix this ASAP.

@sobolevn
Copy link
Member

Fixed in #869

@Fidget-Spinner
Copy link
Member

Yep. Thanks again @sobolevn!

@JelleZijlstra
Copy link
Member

The CI PR might take a while longer so I'm going to try running tests locally myself and then release 3.10.0.2 with the fix.

@srittau
Copy link
Collaborator

srittau commented Aug 30, 2021

@JelleZijlstra Feel free to merge the CI PR. I think it's "good enough" and can be cleaned up later

@JelleZijlstra
Copy link
Member

We need to wait for the CLA to land.

@srittau
Copy link
Collaborator

srittau commented Aug 30, 2021

We need to wait for the CLA to land.

Ah, ok.

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Aug 30, 2021

I'm awfully confused why plain _GenericAlias passed in 3.9 but failed in 3.10 (also I could've sworn that I tested it locally on 3.10 in that implementation and it passed 😞.

Edit: woops nevermind, I see Jelle found out why in #871. -- I was wrong here, please ignore this! That's another unrelated but similar-looking issue.

@mgorny
Copy link

mgorny commented Aug 30, 2021

Note that there were some last-minutes changes in typing in Python 3.10.0rc1, so it might have been that if you were testing on b4.

@AMDmi3
Copy link

AMDmi3 commented Aug 30, 2021

Judging by my runs, it's similarly broken everywhere from 3.10.0-b2 to 3.10.0-rc1.

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Aug 30, 2021

Nevermind, it seems that I'd made a mistake -- I just tested this on 3.10a7 and it didn't pass there either (I think I might've tested just 3.5-3.9). I'm really sorry everyone.

Hopefully our new CI with 3.10 runs will catch such things in the future. I'll make sure to run 3.10 tests locally too.

@JelleZijlstra
Copy link
Member

Update: I just released 3.10.0.2, which passes tests under 3.10.0rc1.

jaraco added a commit to python/importlib_metadata that referenced this issue Sep 13, 2021
beniwohli added a commit to beniwohli/apm-agent-python that referenced this issue Sep 14, 2021
That specific version has a bug on Python 3.10

See python/typing#865
howjmay pushed a commit to howjmay/numpy that referenced this issue Sep 29, 2021
clrpackages pushed a commit to clearlinux-pkgs/importlib_metadata that referenced this issue Nov 12, 2021
…o version 4.8.2

Alan Fregtman (1):
      .editorconfig: Set max_line_length to 88 for Python files.

Jason R. Coombs (16):
      Pin against broken typing-extensions as reported in python/typing#865. Fixes python/importlib_metadata#350.
      Extract list method passthrough into a factory function.
      Refactor Distribution.files to use pass_none to handle a None value from _read_files*.
      Revert "Pin against broken typing-extensions as reported in python/typing#865. Fixes python/importlib_metadata#350."
      Add intersphinx mappings for Python to prevent spurious nitpicky failures. Fixes jaraco/skeleton#51.
      Remove docstring as comment. It's over-specific (pytest-mypy) but also any user of mypy is probably familiar that mypy doesn't handle conditional imports elegantly.
      Test on Python 3.10 (final).
      Rely on pytest 6 and drop workaround for pytest-dev/pytest#6178.
      Remove references to specific Python versions, as this project and CPython are evolving over time.
      Remove more references to specific Python versions.
      Remove wheel from build requirements. It's implied for wheel builds. Ref pypa/setuptools#1498.
      Fall back to legacy resolver in pip. Workaround for pypa/pip#9143.
      Restore new resolver for pip. Proper fix for pypa/pip#9143.
      Add test for FastPath on empty path. Ref #353.
      Restore fallback when FastPath.root is empty. Fixes #353.
      Update changelog. Ref #353.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants