Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch pipeline to Github Actions #866

Merged
merged 5 commits into from
Aug 30, 2021

Conversation

davfsa
Copy link
Contributor

@davfsa davfsa commented Aug 29, 2021

This PR migrates the testing jobs from Travis CI to Github Actions

Also added python 3.10-dev to the CI

Closes #864

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@davfsa

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@davfsa
Copy link
Contributor Author

davfsa commented Aug 29, 2021

I have singed the CLA, waiting for the records to be updated :)

@davfsa
Copy link
Contributor Author

davfsa commented Aug 29, 2021

Some of the pipeline issues are due to #865, but there are some others that are due to the python version not available in Github Actions.

Versions not available are:

  • 3.7.3
  • 3.7.2
  • 3.6.2
  • 3.6.1
  • 3.5.3
  • 3.5.2
  • 3.4

Some versions (like 3.4) can be fixed by specifying a sub version (ie 3.4.10 or 3.4.8), but I am unsure of the versions that you would need/like to have

Available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

@srittau
Copy link
Collaborator

srittau commented Aug 29, 2021

I think we can drop all sub versions, except for 3.4, where we should just use the latest version.

@davfsa davfsa force-pushed the task/switch-to-github-actions branch from bed71e3 to 4fe31e0 Compare August 29, 2021 18:01
@davfsa
Copy link
Contributor Author

davfsa commented Aug 29, 2021

I think we can drop all sub versions, except for 3.4, where we should just use the latest version.

Removed the sub-versions and bumped up 3.4 to 3.4.10

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
- Changes requested
- Split jobs into tests and linting
@davfsa davfsa force-pushed the task/switch-to-github-actions branch from f84cb5f to 90e966a Compare August 29, 2021 18:17
@JelleZijlstra
Copy link
Member

I'm not sure we can afford to drop the sub-versions; typing-extensions is tightly bound to the implementation of typing and unfortunately typing sometimes changes significantly between bugfix versions.

@davfsa
Copy link
Contributor Author

davfsa commented Aug 29, 2021

I'm not sure we can afford to drop the sub-versions; typing-extensions is tightly bound to the implementation of typing and unfortunately typing sometimes changes significantly between bugfix versions.

Unfortunately we are bound to the constraints here. It might be possible to request the python versions in the setup-python repo

Another option (but probably not recommended) would be to use the deadsnakes ppa to download the specific version of python we would need. But even the ppa doesnt have all python versions

@JelleZijlstra
Copy link
Member

For now let's not worry about the micro versions then.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python 3.10 and linter failures are not related to this PR.

@srittau
Copy link
Collaborator

srittau commented Aug 30, 2021

#868 for the linter warnings.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@adiroiban
Copy link

Thanks for the update.
I don't think the names are short enough :p

image

Another option is to use a custom name and add python version first

But I think that this can be merged as it is... as this is a very minor issue.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert your last commit. See my comments above.

@JelleZijlstra JelleZijlstra reopened this Aug 30, 2021
@davfsa davfsa force-pushed the task/switch-to-github-actions branch from 52aaedc to 57a0660 Compare August 30, 2021 16:13
@davfsa
Copy link
Contributor Author

davfsa commented Aug 30, 2021

Please revert your last commit. See my comments above.

Reverted 👍

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 6a6f807 into python:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate CI to GitHub Actions
5 participants