Extract the quantization utils function in FBGEMM #1204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-stroopwafel-199537 canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D37799807 |
Summary: Pull Request resolved: pytorch#1204 This will be better shared between Trec and HPC. - We will refactor https://www.internalfb.com/code/fbsource/[history]/fbcode/caffe2/torch/fb/hpc/quantized_comms_lib.py to extract the common components in FBGEMM - It's open source so TorchRec can call it from FBGEMM. - Reuse the quantize utils functions and dedup the code. This part of code is landable. Differential Revision: D37799807 fbshipit-source-id: a21a41ed40abefbb7ae864a78031391d19296275
|
This pull request was exported from Phabricator. Differential Revision: D37799807 |
jianyuh
force-pushed
the
export-D37799807
branch
from
f84e494 to
5fb444d
Compare
YLGH
pushed a commit
to YLGH/FBGEMM
that referenced
this pull request
Jul 25, 2022
Summary: Pull Request resolved: pytorch#1204 This will be better shared between Trec and HPC. - We will refactor https://www.internalfb.com/code/fbsource/[history]/fbcode/caffe2/torch/fb/hpc/quantized_comms_lib.py to extract the common components in FBGEMM - It's open source so TorchRec can call it from FBGEMM. - Reuse the quantize utils functions and dedup the code. This part of code is landable. Differential Revision: D37799807 fbshipit-source-id: 5c05a200ec3f9a4f0bc0e380dec630bee79db3af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This will be better shared between Trec and HPC.
This part of code is landable.
Differential Revision: D37799807