Add NEON and SVE implementations for Float16 conversions

[annop-w]

No description provided.

[facebook-github-bot]

Hi @annop-w!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[netlify]

✅ Deploy Preview for pytorch-fbgemm-docs ready!

Name	Link
🔨 Latest commit	640e529
🔍 Latest deploy log	https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/674dedeb9bcb5c0008d7081b
😎 Deploy Preview	https://deploy-preview-3424--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[psaab]

diff --git a/fbcode/deeplearning/fbgemm/TARGETS b/fbcode/deeplearning/fbgemm/TARGETS
--- a/fbcode/deeplearning/fbgemm/TARGETS
+++ b/fbcode/deeplearning/fbgemm/TARGETS
@@ -184,6 +184,7 @@
         "-DFBCODE_CAFFE2",
     ],
     exported_deps = [
+        ":fbgemm_base",
         "fbsource//third-party/asmjit:asmjit",
         "fbsource//third-party/cpuinfo:cpuinfo",
         "//common/aarch64:intrinsics_dep",
diff --git a/fbcode/deeplearning/fbgemm/defs.bzl b/fbcode/deeplearning/fbgemm/defs.bzl
--- a/fbcode/deeplearning/fbgemm/defs.bzl
+++ b/fbcode/deeplearning/fbgemm/defs.bzl
@@ -143,7 +143,11 @@
     return asm_srcs if not msvc else intrinsics_srcs
 
 def get_fbgemm_inline_sve_srcs(msvc = False, buck = False):
-    intrinsics_srcs = ["src/FbgemmFP16UKernelsSve128.cc"]
+    intrinsics_srcs = [
+        "src/FbgemmFP16UKernelsSve128.cc",
+        "src/FbgemmFloat16ConvertNeon.cc",
+        "src/FbgemmFloat16ConvertSve.cc"
+    ]
 
     #FP16 kernels contain inline assembly and inline assembly syntax for MSVC is different.
     asm_srcs = ["src/FbgemmFP16UKernelsSve128.cc"]