Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GrokAdamW #1032

Open
mtasic85 opened this issue Oct 8, 2024 · 2 comments
Open

Support for GrokAdamW #1032

mtasic85 opened this issue Oct 8, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@mtasic85
Copy link

mtasic85 commented Oct 8, 2024

Hi there,

It would be great to have support for GrokAdamW optimizer but with low bit quantization.

You can check reference implementation: https://github.com/cognitivecomputations/grokadamw

It has shown promising results already.

@msaroufim msaroufim added the good first issue Good for newcomers label Oct 9, 2024
@msaroufim
Copy link
Member

Hi @mtasic85 for new optimizers generally our take is it's probably not too hard to implement them from scratch using the AdamW code as a reference implementation. If this is something you're interested in lmk we can walk you through how to do this

@p4arth
Copy link
Contributor

p4arth commented Oct 18, 2024

Attempted to implement this here using the AdamW code as suggested by @msaroufim. Was able to get a working implementation, still need to check for correctness and optimizations if any.

r-barnes added a commit to r-barnes/ao that referenced this issue Oct 23, 2024
Summary: Pull Request resolved: facebookincubator/AITemplate#1032

Reviewed By: houseroad

Differential Revision: D64835967
facebook-github-bot pushed a commit that referenced this issue Oct 23, 2024
Differential Revision: D64835967

Pull Request resolved: #1151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants