c10::nullopt -> std::nullopt (#1032) #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: facebookincubator/AITemplate#1032 Reviewed By: houseroad Differential Revision: D64835967
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1151
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit 7b7f774 with merge base d252612 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64835967 |
r-barnes
added a commit
to r-barnes/audio
that referenced
this pull request
Oct 23, 2024
Summary: X-link: pytorch/ao#1151 X-link: facebookincubator/AITemplate#1032 Reviewed By: houseroad Differential Revision: D64835967
This was referenced Oct 23, 2024
r-barnes
added a commit
to r-barnes/executorch
that referenced
this pull request
Oct 23, 2024
Summary: X-link: pytorch/audio#3848 X-link: pytorch/ao#1151 X-link: facebookincubator/AITemplate#1032 Reviewed By: houseroad Differential Revision: D64835967
r-barnes
added a commit
to r-barnes/torchrec
that referenced
this pull request
Oct 23, 2024
Summary: X-link: pytorch/executorch#6461 X-link: pytorch/audio#3848 X-link: pytorch/ao#1151 X-link: facebookincubator/AITemplate#1032 Reviewed By: houseroad Differential Revision: D64835967
|
External tests seem good but not sure what's happening internally |
facebook-github-bot
pushed a commit
to pytorch/FBGEMM
that referenced
this pull request
Oct 23, 2024
Summary: X-link: pytorch/torchrec#2515 X-link: pytorch/executorch#6461 X-link: pytorch/audio#3848 X-link: pytorch/ao#1151 X-link: facebookincubator/AITemplate#1032 Reviewed By: houseroad Differential Revision: D64835967 fbshipit-source-id: 9f9f65335aaf5497680561027ef9314e4b36f8d9
facebook-github-bot
pushed a commit
to pytorch/torchrec
that referenced
this pull request
Oct 23, 2024
Summary: Pull Request resolved: #2515 X-link: pytorch/executorch#6461 X-link: pytorch/audio#3848 X-link: pytorch/ao#1151 X-link: facebookincubator/AITemplate#1032 Reviewed By: houseroad Differential Revision: D64835967 fbshipit-source-id: 9f9f65335aaf5497680561027ef9314e4b36f8d9
facebook-github-bot
pushed a commit
to pytorch/csprng
that referenced
this pull request
Oct 23, 2024
Summary: X-link: pytorch/torchrec#2515 X-link: pytorch/executorch#6461 X-link: pytorch/audio#3848 X-link: pytorch/ao#1151 X-link: facebookincubator/AITemplate#1032 Reviewed By: houseroad Differential Revision: D64835967 fbshipit-source-id: 9f9f65335aaf5497680561027ef9314e4b36f8d9
facebook-github-bot
pushed a commit
to facebookincubator/AITemplate
that referenced
this pull request
Oct 23, 2024
Summary: X-link: pytorch/torchrec#2515 X-link: pytorch/executorch#6461 X-link: pytorch/audio#3848 X-link: pytorch/ao#1151 Pull Request resolved: #1032 Reviewed By: houseroad Differential Revision: D64835967 fbshipit-source-id: 9f9f65335aaf5497680561027ef9314e4b36f8d9
yanbing-j
pushed a commit
to yanbing-j/ao
that referenced
this pull request
Dec 9, 2024
* enable batch decoding, optimize dst/src creation outside of decoding loop * remove logging, update formatting for display * ruff formatting * use Ke's variable names for send/rcv * add formatting exception for llama2 "".res * fix prompt incrementing add formatting exception for llama2 "".res * revert prompt incrementing to pp=1 state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Pull Request resolved: facebookincubator/AITemplate#1032
Reviewed By: houseroad
Differential Revision: D64835967