Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Skip Unit Tests for ROCm CI" #1580

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

andrewor14
Copy link
Contributor

Reverts #1563

Caused CI to fail: https://github.com/pytorch/ao/actions/runs/12833188835/job/35787621495

  /opt/conda/envs/venv/lib/python3.9/importlib/__init__.py:127: in import_module
      return _bootstrap._gcd_import(name[level:], package, level)
  test/quantization/test_marlin_qqq.py:6: in <module>
      from test_utils import skip_if_rocm
  E   ModuleNotFoundError: No module named 'test_utils'

cc @petrex @amdfaa

Copy link

pytorch-bot bot commented Jan 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1580

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Pending

As of commit 5b3fb3e with merge base a1c67b9 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2025
Copy link

pytorch-bot bot commented Jan 17, 2025

Warning: Unknown label ciflow/rocm.
Currently recognized labels are

  • ciflow/benchmark
  • ciflow/tutorials

Please add the new label to .github/pytorch-probot.yml

@andrewor14 andrewor14 requested a review from HDCharles January 17, 2025 16:57
@andrewor14 andrewor14 added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jan 17, 2025
@andrewor14 andrewor14 requested a review from jainapurva January 17, 2025 18:05
@petrex
Copy link
Collaborator

petrex commented Jan 17, 2025

Reverts #1563

Caused CI to fail: https://github.com/pytorch/ao/actions/runs/12833188835/job/35787621495

  /opt/conda/envs/venv/lib/python3.9/importlib/__init__.py:127: in import_module
      return _bootstrap._gcd_import(name[level:], package, level)
  test/quantization/test_marlin_qqq.py:6: in <module>
      from test_utils import skip_if_rocm
  E   ModuleNotFoundError: No module named 'test_utils'

cc @petrex @amdfaa

thanks @andrewor14 #1581

@andrewor14
Copy link
Contributor Author

Looks like the failing tests are caused by #999, which is also being reverted. Merging this.

@andrewor14 andrewor14 merged commit 9afaabb into main Jan 17, 2025
14 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/rocm CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants