New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ROCM in CI #999

Merged

amdfaa merged 4 commits into main from msaroufim-patch-21

Jan 17, 2025

Member

msaroufim commented Oct 3, 2024 •

edited by jithunnair-amd

Loading

Salient points:

Add ROCm nightly wheels to test matrix
Refactor conda-builder -> almalinux-builder pytorch#140157
The above PR shows that we've migrated to almalinux-builder due to the EOL CENTOS 7. Changes to regression_test.yml to not install devtoolset-10 have been made in accordance with this switch.
Fix bug in torchao/utils.py in invocation of torch.cuda.get_device_properties()

Needs changes in pytorch/test-infra#6104

pytorch-bot bot commented Oct 3, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/999

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Pending

As of commit 593fb78 with merge base cedadc7 ():

NEW FAILURES - The following jobs have failed:

Run Regression Tests / test (CUDA 2.4, linux.g5.12xlarge.nvidia.gpu, torch==2.4.0, cuda, 12.1) / linux-job (gh)
test/quantization/test_quant_api.py::TestQuantFlow::test_quantized_tensor_subclass_int8_dyn_quant
Run Regression Tests / test (CUDA 2.5.1, linux.g5.12xlarge.nvidia.gpu, torch==2.5.1 --index-url https://download.pytorch... / linux-job (gh)
test/quantization/test_quant_api.py::TestQuantFlow::test_quantized_tensor_subclass_int8_dyn_quant
Run Regression Tests / test-nightly (ROCM Nightly, linux.rocm.gpu.2, --pre torch --index-url https://download.pytorch.or... / linux-job (gh)
test/sparsity/test_marlin.py::SparseMarlin24::test_quant_sparse_marlin_layout_eager

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added ciflow/rocm module: rocm labels

facebook-github-bot added the CLA Signed label

pytorch-bot bot commented Oct 3, 2024

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

Member Author

msaroufim commented Oct 9, 2024

@atalman im not sure the no-sudo flag does anything. Tried a few variants for the value like true or "true" and same result

atalman reviewed

View reviewed changes

.github/workflows/regression_test.yml Outdated Show resolved Hide resolved

atalman reviewed

View reviewed changes

.github/workflows/regression_test.yml Outdated Show resolved Hide resolved

atalman reviewed

View reviewed changes

.github/workflows/regression_test.yml Outdated Show resolved Hide resolved

This was referenced Oct 15, 2024

Enable Intel GPU #753

Closed

Multibackend tracker #1082

Open

atalman mentioned this pull request

Add support for Rocm Runners to linux_job pytorch/test-infra#5766

Open

Collaborator

amdfaa commented Nov 19, 2024

@pytorchbot rebase

1 similar comment

Collaborator

amdfaa commented Nov 19, 2024

@pytorchbot rebase

amdfaa mentioned this pull request

Enable linux_job.yml workflow for ROCm pytorch/test-infra#6003

Closed

amdfaa reviewed

View reviewed changes

.github/workflows/regression_test.yml Outdated

+                    docker-image: ${{ matrix.gpu-arch-type == 'rocm' && format('pytorch/manylinux2_28-builder:{0}{1}',
+                                                                                    matrix.gpu-arch-type,
+                                                                                    matrix.gpu-arch-version)
+                                                                         || 'pytorch/almalinux-builder' }}

Collaborator

amdfaa Dec 5, 2024

pytorch/pytorch#140157
We've migrated to almalinux-builder due to the EOL CENTOS 7.

amdfaa reviewed

View reviewed changes

.github/workflows/regression_test.yml

                     script: |
                       conda create -n venv python=3.9 -y
                       conda activate venv
                       echo "::group::Install newer objcopy that supports --set-section-alignment"
-                      yum install -y  devtoolset-10-binutils
-                      export PATH=/opt/rh/devtoolset-10/root/usr/bin/:$PATH

Collaborator

amdfaa Dec 5, 2024

The gcctoolset is installed through the dockerfile. Mentioned in this PR: pytorch/pytorch#140157

Collaborator

amdfaa Dec 5, 2024

The same is installed for rocm in this PR: pytorch/pytorch#141609

msaroufim added the topic: not user facing label

jithunnair-amd mentioned this pull request

[ROCm] Update setup-rocm for almalinux-based images pytorch/pytorch#143590

Closed

jithunnair-amd requested changes

View reviewed changes

.github/workflows/regression_test.yml Outdated Show resolved Hide resolved

.github/workflows/regression_test.yml Outdated

                   with:
                     timeout: 120
+                    no-sudo: ${{ matrix.gpu-arch-type == 'rocm' }}
+                    rocm: ${{ matrix.gpu-arch-type == 'rocm' }}
+                    continue-on-error: ${{ matrix.gpu-arch-type == 'rocm' }}

Collaborator

jithunnair-amd Dec 19, 2024

This should definitely not be checked-in, since it's only for us to gather a complete list of test failures. @msaroufim Would we merge this PR only after ROCm CI is fully clean? I'd rather get all these infra changes merged, so that we run torchao CI on ROCm regularly, and maybe skip any failing tests for ROCm while we work separately to enable them.

Member Author

msaroufim Dec 20, 2024 •

edited

Loading

It's up to you, the main constraint is we can't really be having CI per commit or on main run red since then it just causes confusion and people slowly learn to ignore seeing red. So if you'd like to merge some variant of this PR without running on commits to or on main then we can try to merge this more quickly

Personally I'd favor merging the skip tests as part of this work and we can do enablement for tests one by one easily while maintaining a green CI

Collaborator

jithunnair-amd Jan 8, 2025

@petrex Please note that torchao team would like to have this PR be merged with a clean signal for ROCm, so please skip any failing tests as part of this PR

Collaborator

petrex Jan 14, 2025

done . #1563 based on the latest ROCm CI run

pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request


          [ROCm] Update setup-rocm for almalinux-based images (#143590)

a3b04d4

Needed for pytorch/test-infra#6003 and pytorch/ao#999

Pull Request resolved: #143590
Approved by: https://github.com/atalman

Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>

amdfaa mentioned this pull request

Enable linux_job_v2.yml workflow for ROCm pytorch/test-infra#6104

Merged

Collaborator

petrex commented Jan 6, 2025

happy new year @jithunnair-amd @amdfaa Is this feature/PR ready to deploy?

Collaborator

jithunnair-amd commented Jan 8, 2025

happy new year @jithunnair-amd @amdfaa Is this feature/PR ready to deploy?

2 pending items:

Resolve issue with aws credentials causing some steps to fail in CI job eg. https://github.com/pytorch/ao/actions/runs/12656214677/job/35268262299#step:17:39 : this one needs pytorch infra team to enable "AWS trust policy" for torchao repository cc @huydhn to submit a PR for that
Skip any failing unit tests for ROCm as part of this PR as per Enable ROCM in CI #999 (comment) cc @petrex to add skips to this PR

Contributor

huydhn commented Jan 8, 2025

1. Resolve issue with aws credentials causing some steps to fail in CI job eg. https://github.com/pytorch/ao/actions/runs/12656214677/job/35268262299#step:17:39 : this one needs pytorch infra team to enable "AWS trust policy" for torchao repository cc @huydhn to submit a PR for that

The credential is working now. There is a new failure w.r.t chown on the CI job https://github.com/pytorch/ao/actions/runs/12656214677/job/35334719646, but it’s a different story I think

amdfaa force-pushed the msaroufim-patch-21 branch from f75c6a0 to 17289e7 Compare

January 10, 2025 23:44


          Enable ROCM in CI

cb1331d

amdfaa force-pushed the msaroufim-patch-21 branch from 17289e7 to cb1331d Compare

January 11, 2025 00:01

petrex mentioned this pull request

Skip Unit Tests for ROCm CI #1563

Merged

Collaborator

petrex commented Jan 14, 2025

@msaroufim I dont seem to have access to this branch so #1563 instead.
@amdfaa please kick off a new ROCm CI run with #1563
thanks!

Collaborator

petrex commented Jan 14, 2025

happy new year @jithunnair-amd @amdfaa Is this feature/PR ready to deploy?

2 pending items:

Resolve issue with aws credentials causing some steps to fail in CI job eg. https://github.com/pytorch/ao/actions/runs/12656214677/job/35268262299#step:17:39 : this one needs pytorch infra team to enable "AWS trust policy" for torchao repository cc @huydhn to submit a PR for that

Skip any failing unit tests for ROCm as part of this PR as per Enable ROCM in CI #999 (comment) cc @petrex to add skips to this PR

amdfaa added a commit to pytorch/test-infra that referenced this pull request


          Enable linux_job_v2.yml workflow for ROCm (#6104)

15110a3

Relates to pytorch/ao#999

Needs pytorch/pytorch#143590

amdfaa added 3 commits

January 16, 2025 13:57


          Update regression_test.yml

e54e154


          Update regression_test.yml

7ca8cdf


          Update regression_test.yml

593fb78

amdfaa merged commit d96c6a7 into main

15 of 18 checks passed

Contributor

andrewor14 commented Jan 17, 2025

Hi @amdfaa, looks like this PR is still failing tests when landed. It's causing other unrelated PRs to fail the same tests: https://hud.pytorch.org/pr/pytorch/ao/1580#35788489448. Please make sure the tests are passing before landing.

andrewor14 added a commit that referenced this pull request


          Revert "Enable ROCM in CI (#999)"

b07f714

This reverts commit d96c6a7.

This was referenced Jan 17, 2025

Revert "Enable ROCM in CI" #1583

Merged

Revert "Skip Unit Tests for ROCm CI" #1580

Merged

andrewor14 added a commit that referenced this pull request


          Revert "Enable ROCM in CI" (#1583)

1240b19

Revert "Enable ROCM in CI (#999)"

This reverts commit d96c6a7.

andrewor14 mentioned this pull request

[Reland] ROCm CI (Infra + Skips) #1581

Open

petrex pushed a commit to petrex/ao that referenced this pull request


          Enable ROCM in CI (pytorch#999)

5bc0709

* Enable ROCM in CI

---------

Co-authored-by: amdfaa <107946068+amdfaa@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/rocm CLA Signed module: rocm topic: not user facing