Update audio data augmentation tutorial #2388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| # 1. Preparation | ||
| # -------------- | ||
| # | ||
| # Firstly, we import the modules and download the audio assets we use in this tutorial. |
There was a problem hiding this comment.
Suggested change
| # Firstly, we import the modules and download the audio assets we use in this tutorial. | |
| # First, we import the modules and download the audio assets we use in this tutorial. |
| ###################################################################### | ||
| # Original: | ||
| # ~~~~~~~~~ | ||
| # --------- |
There was a problem hiding this comment.
I prefer the original section organization with the subsections (left) over this updated version (right). imo the lack of indentation makes it look cluttered and harder to navigate, thoughts?
- Adopt `torchaudio.utils.download_asset` to simplify asset management. - Break down the first section about helper functions. - Reduce the number of helper functions - Add section number
mthrok
force-pushed
the
update-audio-augmentation-tutorial
branch
from
a8c10ba to
dcdaa33
Compare
carolineechen
approved these changes
Jun 2, 2022
Co-authored-by: Caroline Chen <carolinechen@fb.com>
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey @mthrok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torchaudio.utils.download_assetto simplify asset management.https://output.circle-artifacts.com/output/job/d7dd1b93-6dfe-46da-a080-109bfdc63881/artifacts/0/docs/tutorials/audio_data_augmentation_tutorial.html