-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BC-breaking] Remove file-like object support from sox_io backend #3035
Conversation
d8ccae8
to
8a29fd7
Compare
8a29fd7
to
d7f2933
Compare
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
6e986be
to
5b994fd
Compare
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
5b994fd
to
6d20e3a
Compare
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3035
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 0e2f0ed: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
6d20e3a
to
729f28a
Compare
729f28a
to
ba215bf
Compare
d2e36ea
to
04d7ab4
Compare
c0b1056
to
b915b5a
Compare
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
b915b5a
to
bcffe7d
Compare
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
bcffe7d
to
0e2f0ed
Compare
This pull request was exported from Phabricator. Differential Revision: D44695647 |
Hey @mthrok. Some guidance:Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss). Things in "examples" directory:
Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes. When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'. Things related to build are by default excluded from the release note, except when it impacts users. For example: |
This commit removes file-like obejct support so that we can remove custom patch
The motivation and plan is outlined in #2950.