Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BC-breaking] Remove file-like object support from sox_io backend #3035

Closed
wants to merge 1 commit into from

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Feb 6, 2023

This commit removes file-like obejct support so that we can remove custom patch

The motivation and plan is outlined in #2950.

@facebook-github-bot
Copy link
Contributor

@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mthrok mthrok force-pushed the remove-sox-fileobj branch 3 times, most recently from 6e986be to 5b994fd Compare April 6, 2023 00:29
@facebook-github-bot
Copy link
Contributor

@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mthrok mthrok force-pushed the remove-sox-fileobj branch from 5b994fd to 6d20e3a Compare May 10, 2023 00:58
@pytorch-bot
Copy link

pytorch-bot bot commented May 10, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3035

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 0e2f0ed:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mthrok mthrok force-pushed the remove-sox-fileobj branch from 6d20e3a to 729f28a Compare May 10, 2023 02:25
@mthrok mthrok mentioned this pull request May 10, 2023
6 tasks
@mthrok mthrok changed the title Remove file-like object support from sox_io backend [BC-breaking] Remove file-like object support from sox_io backend May 10, 2023
@mthrok mthrok force-pushed the remove-sox-fileobj branch from 729f28a to ba215bf Compare May 10, 2023 13:49
@mthrok mthrok closed this May 11, 2023
@mthrok mthrok reopened this May 11, 2023
@mthrok mthrok force-pushed the remove-sox-fileobj branch 3 times, most recently from d2e36ea to 04d7ab4 Compare May 19, 2023 20:25
@mthrok mthrok force-pushed the remove-sox-fileobj branch 5 times, most recently from c0b1056 to b915b5a Compare June 1, 2023 04:53
@facebook-github-bot
Copy link
Contributor

@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mthrok mthrok force-pushed the remove-sox-fileobj branch from b915b5a to bcffe7d Compare June 1, 2023 12:06
@facebook-github-bot
Copy link
Contributor

@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mthrok mthrok marked this pull request as ready for review June 1, 2023 12:09
)

Summary:
This commit removes file-like obejct support so that we can remove custom patch

The motivation and plan is outlined in #2950.

Pull Request resolved: #3035

Differential Revision: D44695647

Pulled By: mthrok

fbshipit-source-id: af1efd5c2f6f861ee34fc3d08a6703618206a100
@mthrok mthrok force-pushed the remove-sox-fileobj branch from bcffe7d to 0e2f0ed Compare June 1, 2023 16:17
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44695647

@facebook-github-bot
Copy link
Contributor

@mthrok merged this pull request in bc54ac8.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Hey @mthrok.
You merged this PR, but labels were not properly added. Please add a primary and secondary label (See https://github.com/pytorch/audio/blob/main/.github/process_commit.py).


Some guidance:

Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss).

Things in "examples" directory:

  • 'recipe' is applicable to training recipes under the 'examples' folder,
  • 'tutorial' is applicable to tutorials under the “examples/tutorials” folder
  • 'example' is applicable to everything else (e.g. C++ examples)
  • 'module: docs' is applicable to code documentations (not to tutorials).
    Regarding examples in code documentations, please also use 'module: docs'.

Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes.


When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'.

Things related to build are by default excluded from the release note, except when it impacts users. For example:
* Drop support of Python 3.7.
* Add support of Python 3.X.
* Change the way a third party library is bound (so that user needs to install it separately).

@mthrok mthrok deleted the remove-sox-fileobj branch June 1, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants