Merge FixedNoiseGP into SingleTaskGP #2052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50392099 |
Codecov Report
@@ Coverage Diff @@
## main #2052 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 179 179
Lines 15847 15822 -25
=========================================
- Hits 15847 15822 -25
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Supporting an optional `train_Yvar` argument in `SingleTaskGP` eliminates the need for an additional model class just to have a different likelihood. The plan for `FixedNoiseGP` is for it to live along with a soft deprecation warning for the foreseeable future. Differential Revision: D50392099
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: D50393050
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Supporting an optional `train_Yvar` argument in `SingleTaskGP` eliminates the need for an additional model class just to have a different likelihood. The plan for `FixedNoiseGP` is for it to live along with a soft deprecation warning for the foreseeable future. Differential Revision: D50392099
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: D50393050
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Supporting an optional `train_Yvar` argument in `SingleTaskGP` eliminates the need for an additional model class just to have a different likelihood. The plan for `FixedNoiseGP` is for it to live along with a soft deprecation warning for the foreseeable future. Differential Revision: D50392099
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: D50393050
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Supporting observed noise was blocked on `SingleTaskGP` not supporting `train_Yvar`. We can easily support it after pytorch#2052 Differential Revision: D50394746
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: https://internalfb.com/D50393050 fbshipit-source-id: e5f628d5da8b51dd6aadc1f09e9abd25cfb2ae64
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Supporting observed noise was blocked on `SingleTaskGP` not supporting `train_Yvar`. We can easily support it after pytorch#2052 Differential Revision: D50394746 fbshipit-source-id: ef2fb1d1bc7973449d90b15fcfe3f095f896fab5
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Updates use cases of fixed noise models that were deprecated in pytorch#2052 & elsewhere. I'll update Ax usage in a separate diff. Differential Revision: D50429032 fbshipit-source-id: 12670106b6e686496b3125b9307f6bab88094ad7
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 18, 2023
Summary: Updates use cases of fixed noise models that were deprecated in pytorch/botorch#2052 & elsewhere. The only remaining usage is `botorch_modular_registry`. I updated these to point to the parent models, so that they'll be less likely to cause backwards compatibility issues when we delete the models for good. Differential Revision: D50431137 fbshipit-source-id: ec69453b3de528833308572a3fd2b7109747a6a8
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: https://internalfb.com/D50393050 fbshipit-source-id: 8ee47d06caede6f918bdb1b62f953016e6b5031d
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Supporting observed noise was blocked on `SingleTaskGP` not supporting `train_Yvar`. We can easily support it after pytorch#2052 Differential Revision: D50394746 fbshipit-source-id: d0b55df78c61a193892392c9b3333dc1196b1ff1
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Updates use cases of fixed noise models that were deprecated in pytorch#2052 & elsewhere. I'll update Ax usage in a separate diff. Differential Revision: D50429032 fbshipit-source-id: 09f6d7ebfee22da617e4681aca55a49602a4f4a3
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 18, 2023
Summary: Updates use cases of fixed noise models that were deprecated in pytorch/botorch#2052 & elsewhere. The only remaining usage is `botorch_modular_registry`. I updated these to point to the parent models, so that they'll be less likely to cause backwards compatibility issues when we delete the models for good. Differential Revision: D50431137 fbshipit-source-id: aecf057d724a5986c8cfd8cbc29673c4b5066ef6
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: https://internalfb.com/D50393050 fbshipit-source-id: dcb19a14bf2ac799720e7c63371766a8c60e6154
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#2054 Supporting observed noise was blocked on `SingleTaskGP` not supporting `train_Yvar`. We can easily support it after pytorch#2052 Reviewed By: esantorella Differential Revision: D50394746 fbshipit-source-id: d830d92031b4c3a1b190ce438cdf0513130ae2b0
|
This pull request was exported from Phabricator. Differential Revision: D50392099 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#2052 Supporting an optional `train_Yvar` argument in `SingleTaskGP` eliminates the need for an additional model class just to have a different likelihood. The plan for `FixedNoiseGP` is for it to live along with a soft deprecation warning for the foreseeable future. Reviewed By: esantorella Differential Revision: D50392099 fbshipit-source-id: 3865a85547513df58da0acca48c3e93eac2da4ad
saitcakmak
force-pushed
the
export-D50392099
branch
from
0d7420e
to
6e9505b
Compare
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: D50393050 fbshipit-source-id: 44dfea109701f5b033889358fdd5222af1c5cda9
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: https://internalfb.com/D50393050 fbshipit-source-id: 710d6c6da7eccb02f944d01996d27fa55c7ed4cb
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Supporting observed noise was blocked on `SingleTaskGP` not supporting `train_Yvar`. We can easily support it after pytorch#2052 Differential Revision: D50394746 fbshipit-source-id: 925746f6aa3774e4805c6c67316650817534b40f
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#2059 Updates use cases of fixed noise models that were deprecated in pytorch#2052 & elsewhere. I'll update Ax usage in a separate diff. Reviewed By: esantorella Differential Revision: D50429032 fbshipit-source-id: 073afbd250b2f11f6206f237c697e3a4c8d94be9
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: facebook#1920 Updates use cases of fixed noise models that were deprecated in pytorch/botorch#2052 & elsewhere. The only remaining usage is `botorch_modular_registry`. I updated these to point to the parent models, so that they'll be less likely to cause backwards compatibility issues when we delete the models for good. Reviewed By: esantorella Differential Revision: D50431137 fbshipit-source-id: 604090019cfff8bc27ae01341a43d80142ef89c8
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 19, 2023
Summary: Updates use cases of fixed noise models that were deprecated in pytorch/botorch#2052 & elsewhere. The only remaining usage is `botorch_modular_registry`. I updated these to point to the parent models, so that they'll be less likely to cause backwards compatibility issues when we delete the models for good. Reviewed By: esantorella Differential Revision: D50431137 fbshipit-source-id: 4bfda383a2a8c55602b04de458aa64a9eae5b175
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 19, 2023
Summary: Pull Request resolved: facebook#1922 Updates use cases of fixed noise models that were deprecated in pytorch/botorch#2052 & elsewhere. The only remaining usage is `botorch_modular_registry`. I updated these to point to the parent models, so that they'll be less likely to cause backwards compatibility issues when we delete the models for good. Reviewed By: esantorella Differential Revision: D50431137 fbshipit-source-id: caf2e35ea714fdc4427c9cfd01385ef01e4e350e
Summary: Pull Request resolved: pytorch#2052 Supporting an optional `train_Yvar` argument in `SingleTaskGP` eliminates the need for an additional model class just to have a different likelihood. The plan for `FixedNoiseGP` is for it to live along with a soft deprecation warning for the foreseeable future. Reviewed By: esantorella Differential Revision: D50392099 fbshipit-source-id: 3070f0dcdfbaf82122dc8dff865d3653fddb34f7
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 19, 2023
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Reviewed By: Balandat Differential Revision: D50393050 fbshipit-source-id: 57ef592e2281d2ffdb85a1d3ea06e741c35df904
|
This pull request was exported from Phabricator. Differential Revision: D50392099 |
saitcakmak
force-pushed
the
export-D50392099
branch
from
6e9505b
to
c703199
Compare
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 19, 2023
Summary: Pull Request resolved: facebook#1922 Updates use cases of fixed noise models that were deprecated in pytorch/botorch#2052 & elsewhere. The only remaining usage is `botorch_modular_registry`. I updated these to point to the parent models, so that they'll be less likely to cause backwards compatibility issues when we delete the models for good. Reviewed By: esantorella Differential Revision: D50431137 fbshipit-source-id: 8083cee08db9e3ad7526b10948cfbeb05f50cd2b
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 19, 2023
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: https://internalfb.com/D50393050 fbshipit-source-id: 8e417e089cdef694f2ec0891b286c18477673037
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 19, 2023
Summary: Pull Request resolved: pytorch#2054 Supporting observed noise was blocked on `SingleTaskGP` not supporting `train_Yvar`. We can easily support it after pytorch#2052 Reviewed By: esantorella Differential Revision: D50394746 fbshipit-source-id: 54b87ce99db243d8e6ce88a33a7023edf5338d4c
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 19, 2023
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: https://internalfb.com/D50393050 fbshipit-source-id: f780903926c108117c7978bdde7c4357a712a50b
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 19, 2023
Summary: Supporting observed noise was blocked on `SingleTaskGP` not supporting `train_Yvar`. We can easily support it after pytorch#2052 Differential Revision: D50394746 fbshipit-source-id: 88962d7cbd3e28b2bb150c72fc25fd4f96c52159
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 19, 2023
Summary: Pull Request resolved: pytorch#2059 Updates use cases of fixed noise models that were deprecated in pytorch#2052 & elsewhere. I'll update Ax usage in a separate diff. Reviewed By: esantorella Differential Revision: D50429032 fbshipit-source-id: 990536e54077dcc9d752c583a2f5456ba75999d5
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 19, 2023
Summary: Pull Request resolved: facebook#1922 Updates use cases of fixed noise models that were deprecated in pytorch/botorch#2052 & elsewhere. The only remaining usage is `botorch_modular_registry`. I updated these to point to the parent models, so that they'll be less likely to cause backwards compatibility issues when we delete the models for good. Reviewed By: esantorella Differential Revision: D50431137 fbshipit-source-id: 53b6a216cb65f6833efa856a46000e1199431398
|
This pull request has been merged in 64a1fb4. |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Oct 19, 2023
Summary: Pull Request resolved: #1922 Updates use cases of fixed noise models that were deprecated in pytorch/botorch#2052 & elsewhere. The only remaining usage is `botorch_modular_registry`. I updated these to point to the parent models, so that they'll be less likely to cause backwards compatibility issues when we delete the models for good. Reviewed By: esantorella Differential Revision: D50431137 fbshipit-source-id: 1839ea59036b8006502aed831dc949adbe5d913e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Supporting an optional
train_Yvarargument inSingleTaskGPeliminates the need for an additional model class just to have a different likelihood.The plan for
FixedNoiseGPis for it to live along with a soft deprecation warning for the foreseeable future.Differential Revision: D50392099