Update use cases of deprecated fixed-noise models #2059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saitcakmak
force-pushed
the
export-D50429032
branch
from
2599faa
to
810ede0
Compare
Codecov Report
@@ Coverage Diff @@
## main #2059 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 179 179
Lines 15847 15803 -44
=========================================
- Hits 15847 15803 -44
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request was exported from Phabricator. Differential Revision: D50429032 |
saitcakmak
force-pushed
the
export-D50429032
branch
from
810ede0
to
4690ea9
Compare
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#2059 Updates use cases of fixed noise models that were deprecated in pytorch#2052 & elsewhere. I'll update Ax usage in a separate diff. Reviewed By: esantorella Differential Revision: D50429032 fbshipit-source-id: 073afbd250b2f11f6206f237c697e3a4c8d94be9
facebook-github-bot
added
the
CLA Signed
Summary: Supporting an optional `train_Yvar` argument in `SingleTaskGP` eliminates the need for an additional model class just to have a different likelihood. The plan for `FixedNoiseGP` is for it to live along with a soft deprecation warning for the foreseeable future. Differential Revision: D50392099 fbshipit-source-id: 08d436179137e764efded7f463ff0036bf7f0135
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: https://internalfb.com/D50393050 fbshipit-source-id: f780903926c108117c7978bdde7c4357a712a50b
Summary: Supporting observed noise was blocked on `SingleTaskGP` not supporting `train_Yvar`. We can easily support it after pytorch#2052 Differential Revision: D50394746 fbshipit-source-id: 88962d7cbd3e28b2bb150c72fc25fd4f96c52159
Summary: Pull Request resolved: pytorch#2059 Updates use cases of fixed noise models that were deprecated in pytorch#2052 & elsewhere. I'll update Ax usage in a separate diff. Reviewed By: esantorella Differential Revision: D50429032 fbshipit-source-id: 990536e54077dcc9d752c583a2f5456ba75999d5
|
This pull request was exported from Phabricator. Differential Revision: D50429032 |
saitcakmak
force-pushed
the
export-D50429032
branch
from
4690ea9
to
7658c2d
Compare
|
This pull request has been merged in 07f2424. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updates use cases of fixed noise models that were deprecated in #2052 & elsewhere.
I'll update Ax usage in a separate diff.
Differential Revision: D50429032